Skip to content

Roi - #65

Merged
sainijit merged 6 commits into
intel-retail:mainfrom
TanmayeeSharvani22:roi
Jul 28, 2026
Merged

Roi#65
sainijit merged 6 commits into
intel-retail:mainfrom
TanmayeeSharvani22:roi

Conversation

@TanmayeeSharvani22

Copy link
Copy Markdown
Contributor

Added support for configurable RTSP source modes.

Changes:

  • Added support for sample and live RTSP source modes.
  • Added configurable camera device support for live streaming.
  • Updated docker-compose.yml and .env.example.
  • Updated the user guide with the new configuration and usage.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds configuration-driven control over the RTSP streamer’s input source (bundled sample clips vs. a live V4L2 camera device) and enhances the queue-service overlay/tracking metadata to better visualize ROI status, alongside documentation and Compose/env updates to support the new workflows.

Changes:

  • Added RTSP_SOURCE_MODE (sample / live) and live camera streaming support in the RTSP streamer.
  • Extended queue-service tracking state and overlay behavior (including enabling overlays when the API is enabled).
  • Updated Docker Compose, .env.example, and the user guide for the new configuration options.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
smart-kiosk-assistant/rtsp-streamer/start.sh Adds RTSP_SOURCE_MODE selection and a live camera (V4L2) ffmpeg publishing path.
smart-kiosk-assistant/queue-service/src/queue_counter.py Extends per-track state and draws per-track ROI overlays; enables overlay for API streaming.
smart-kiosk-assistant/queue-service/src/pipeline.py Adds gvawatermark configuration and updates debug/API chain documentation.
smart-kiosk-assistant/queue-service/conf/queue-config.yaml Updates ROI defaults and debug thresholds; changes visualization defaults.
smart-kiosk-assistant/docs/user-guide/get-started.md Documents switching between sample and live RTSP source modes.
smart-kiosk-assistant/docker-compose.yml Adds env wiring for RTSP_SOURCE_MODE/CAMERA_DEVICE and device passthrough configuration.
smart-kiosk-assistant/.env.example Adds example RTSP source configuration and documents MEDIA_FILES behavior.
Comments suppressed due to low confidence (1)

smart-kiosk-assistant/queue-service/src/pipeline.py:289

  • Same issue as above: this docstring claims gvawatermark ROI drawing is disabled, but _element_properties() only returns displ-cfg when model.class_label is set. Clarify the conditional behavior.
        new-sample signal feeds frame_buffer. gvawatermark's person ROI drawing
        is disabled so QueueCounter owns the final box colors. Used when
        api.enabled=true and visualization=false.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread smart-kiosk-assistant/queue-service/src/queue_counter.py Outdated
Comment thread smart-kiosk-assistant/queue-service/src/queue_counter.py Outdated
Comment thread smart-kiosk-assistant/queue-service/conf/queue-config.yaml Outdated
Comment thread smart-kiosk-assistant/docker-compose.yml
Comment thread smart-kiosk-assistant/rtsp-streamer/start.sh Outdated
Comment thread smart-kiosk-assistant/rtsp-streamer/start.sh Outdated
Comment thread smart-kiosk-assistant/queue-service/src/pipeline.py Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@sainijit
sainijit merged commit dcff390 into intel-retail:main Jul 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants