Roi - #65
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds configuration-driven control over the RTSP streamer’s input source (bundled sample clips vs. a live V4L2 camera device) and enhances the queue-service overlay/tracking metadata to better visualize ROI status, alongside documentation and Compose/env updates to support the new workflows.
Changes:
- Added
RTSP_SOURCE_MODE(sample/live) and live camera streaming support in the RTSP streamer. - Extended queue-service tracking state and overlay behavior (including enabling overlays when the API is enabled).
- Updated Docker Compose,
.env.example, and the user guide for the new configuration options.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| smart-kiosk-assistant/rtsp-streamer/start.sh | Adds RTSP_SOURCE_MODE selection and a live camera (V4L2) ffmpeg publishing path. |
| smart-kiosk-assistant/queue-service/src/queue_counter.py | Extends per-track state and draws per-track ROI overlays; enables overlay for API streaming. |
| smart-kiosk-assistant/queue-service/src/pipeline.py | Adds gvawatermark configuration and updates debug/API chain documentation. |
| smart-kiosk-assistant/queue-service/conf/queue-config.yaml | Updates ROI defaults and debug thresholds; changes visualization defaults. |
| smart-kiosk-assistant/docs/user-guide/get-started.md | Documents switching between sample and live RTSP source modes. |
| smart-kiosk-assistant/docker-compose.yml | Adds env wiring for RTSP_SOURCE_MODE/CAMERA_DEVICE and device passthrough configuration. |
| smart-kiosk-assistant/.env.example | Adds example RTSP source configuration and documents MEDIA_FILES behavior. |
Comments suppressed due to low confidence (1)
smart-kiosk-assistant/queue-service/src/pipeline.py:289
- Same issue as above: this docstring claims gvawatermark ROI drawing is disabled, but
_element_properties()only returnsdispl-cfgwhenmodel.class_labelis set. Clarify the conditional behavior.
new-sample signal feeds frame_buffer. gvawatermark's person ROI drawing
is disabled so QueueCounter owns the final box colors. Used when
api.enabled=true and visualization=false.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
avinash-palleti
previously approved these changes
Jul 28, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
sainijit
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for configurable RTSP source modes.
Changes:
sampleandliveRTSP source modes.docker-compose.ymland.env.example.