Remove Usage of std::set in ResidencySet

Removes usage of std::set in ResidencySet and replaces it with a vector.
This does allow duplicat heaps to be inserted into the ResidencySet,
however insertion will be O(1) instead of O(log(n)) and instead we can
easily identify duplicate heaps by checking their last used fence value
when when they are iterated.

src/gpgmm/d3d12/ResidencyManagerD3D12.cpp

@@ -598,6 +598,12 @@ namespace gpgmm::d3d12 {
                 continue;
             }
 
+            // ResidencySet can contain duplicates. We can skip them by checking if the heap's last
+            // used fence is the same as the current one.
+            if (heap->GetLastUsedFenceValue() == mFence->GetCurrentFence()) {
+                continue;
+            }
+
             if (heap->IsInResidencyLRUCache()) {
                 // If the heap is already in the LRU, we must remove it and append again below to
                 // update its position in the LRU.

src/gpgmm/d3d12/ResidencySetD3D12.cpp

@@ -30,22 +30,21 @@ namespace gpgmm::d3d12 {
         if (pHeap == nullptr) {
             return E_INVALIDARG;
         }
-        if (mSet.insert(pHeap).second) {
-            return S_OK;
-        }
-        return S_FALSE;
+
+        mSet.push_back(pHeap);
+        return S_OK;
     }
 
     HRESULT ResidencySet::Reset() {
         mSet.clear();
         return S_OK;
     }
 
-    ResidencySet::UnderlyingType::iterator ResidencySet::begin() const {
+    ResidencySet::UnderlyingType::const_iterator ResidencySet::begin() const {
         return mSet.begin();
     }
 
-    ResidencySet::UnderlyingType::iterator ResidencySet::end() const {
+    ResidencySet::UnderlyingType::const_iterator ResidencySet::end() const {
         return mSet.end();
     }
 

src/gpgmm/d3d12/ResidencySetD3D12.h

@@ -18,7 +18,7 @@
 #include "gpgmm/d3d12/d3d12_platform.h"
 #include "include/gpgmm_export.h"
 
-#include <set>
+#include <vector>
 
 namespace gpgmm::d3d12 {
 
@@ -60,10 +60,10 @@ namespace gpgmm::d3d12 {
         */
         HRESULT Reset();
 
-        using UnderlyingType = std::set<Heap*>;
+        using UnderlyingType = std::vector<Heap*>;
 
-        UnderlyingType::iterator begin() const;
-        UnderlyingType::iterator end() const;
+        UnderlyingType::const_iterator begin() const;
+        UnderlyingType::const_iterator end() const;
 
       private:
         const char* GetTypename() const;

src/tests/end2end/D3D12ResidencyManagerTests.cpp

@@ -172,7 +172,7 @@ TEST_F(D3D12ResidencyManagerTests, CreateResidencySet) {
         ResidencySet setA;
         ASSERT_SUCCEEDED(setA.Insert(allocation->GetMemory()));
         ResidencySet setB(setA);
-        EXPECT_EQ(setA.Insert(allocation->GetMemory()), S_FALSE);
+        EXPECT_EQ(setA.Insert(allocation->GetMemory()), S_OK);
         ResidencySet setC;
         EXPECT_EQ(setC.Insert(allocation->GetMemory()), S_OK);
     }