Correctly identify configuration files in RPM spec files #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RPM spec files it is desirable to prefix configuration files with "%config"
in order to preserve/save any user modifications during RPM upgrade.
Fix sgx-ra-service.spec:
The spec file attempts to prefix "/etc/rad.conf" with prefix %config.
There is no /etc/rad.conf file being packaged. The configuration file
that is actually packaged is "/etc/mpa_registration.conf".
Fix sgx-pck-id-retrieval-tool.spec
The spec file attempts to prefix "/etc/rad.conf" with prefix %config.
There is no /etc/rad.conf file being packaged. The config file we actually
want to prefix with %config is "network_setting.conf". Although this file
is distributed, it is not listed in "%{_specdir}/list-%name".
"%{_specdir}/list-%name" only contains the name of the installation folder
"%{_install_path}". It is unclear if this was intended, most likely not.
Hence we cannot use "sed" for prefixing. Instead of mdifying a presumably
existing line with "sed" we simply append "%{_specdir}/list-%name" with the
desired line.
Signed-off-by: Juro Bystricky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RPM spec files it is desirable to prefix configuration files with "%config"
in order to preserve/save any user modifications during RPM upgrade.
Fix sgx-ra-service.spec:
The spec file attempts to prefix "/etc/rad.conf" with prefix %config.
There is no /etc/rad.conf file being packaged. The configuration file
that is actually packaged is "/etc/mpa_registration.conf".
Fix sgx-pck-id-retrieval-tool.spec
The spec file attempts to prefix "/etc/rad.conf" with prefix %config.
There is no /etc/rad.conf file being packaged. The config file we actually
want to prefix with %config is "network_setting.conf". Although this file
is distributed, it is not listed in "%{_specdir}/list-%name".
"%{_specdir}/list-%name" only contains the name of the installation folder
"%{_install_path}". It is unclear if this was intended, most likely not.
Hence we cannot use "sed" for prefixing. Instead of mdifying a presumably
existing line with "sed" we simply append "%{_specdir}/list-%name" with the
desired line.
Signed-off-by: Juro Bystricky [email protected]