Skip to content
This repository was archived by the owner on Mar 28, 2018. It is now read-only.

build: Update cc-oci-runtime obs builds with master #919

Merged
merged 1 commit into from
May 19, 2017

Conversation

gorozco1
Copy link
Contributor

@gorozco1 gorozco1 commented May 18, 2017

Tis commit adds improvements to the OBS automation tooling for cc-oci-runtime, and the updated changelog sent to the OBS builds.

Signed-off-by: Geronimo Orozco [email protected]

@gorozco1 gorozco1 force-pushed the obs-cc-oci-runtime-2.1.8 branch from 1966da1 to 2ade9f2 Compare May 18, 2017 17:39
@jcvenegas
Copy link
Contributor

hi @gorozco1 , I would prefer to merge #911 , because we will need to remove this for next release(tomorrow). We only need approval from @rcaballeromx in #911

@chavafg
Copy link
Contributor

chavafg commented May 18, 2017

qa-passed

Approved with PullApprove

@jcvenegas
Copy link
Contributor

@gorozco1 #911 merged :D

@gorozco1 gorozco1 force-pushed the obs-cc-oci-runtime-2.1.8 branch from 2ade9f2 to 5b911a2 Compare May 18, 2017 21:35
@gorozco1 gorozco1 changed the title build: Update cc-oci-runtime automation with 2.1.8 build: Update cc-oci-runtime automation with master May 18, 2017
@gorozco1 gorozco1 changed the title build: Update cc-oci-runtime automation with master build: Update cc-oci-runtime obs builds with master May 18, 2017
@chavafg
Copy link
Contributor

chavafg commented May 18, 2017

qa-passed

@@ -8,10 +8,14 @@ With these files we generated Fedora and Ubuntu packages for this component.

``./update_runtime.sh [VERSION]``

``VERSION`` parameter is optional, it can be a tag, a branch or a git hash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing full-stop. I'd also start this sentence with "The".

``VERSION`` parameter is optional, it can be a tag, a branch or a git hash

If no ``VERSION`` is specified to the script, it will get it from the one
specified in the ``configure.ac`` file found at the the repository's root.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd simplify and just say something like:

If VERSION is not specified, it will be determined automatically from the top-level configure.ac file.

@@ -42,19 +43,23 @@ sed "s/@HASH_TAG@/$hash_tag/g;" update_commit_id.patch-template > update_commit_
# Update and package OBS
if [ "$OBS_PUSH" = true ]
then
osc co home:clearlinux:preview:clear-containers-staging/cc-oci-runtime
temp=`basename $0`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actually a problem, but I'd use $( ... ) rather than `...` as it is much clearer (atleast it is to my eyes ;)

@jodh-intel
Copy link
Contributor

Hi @gorozco1 - could you fix the typo in the commit ("Tis")?

@gorozco1 gorozco1 force-pushed the obs-cc-oci-runtime-2.1.8 branch from 5b911a2 to 09e4d8d Compare May 19, 2017 15:38
@gorozco1
Copy link
Contributor Author

@jodh-intel thanks for the feedback all changes you suggested are done

@jodh-intel
Copy link
Contributor

jodh-intel commented May 19, 2017

Thanks @gorozco1. @rcaballeromx - could you review please?

lgtm

Approved with PullApprove

@chavafg
Copy link
Contributor

chavafg commented May 19, 2017

qa-passed

@gorozco1
Copy link
Contributor Author

@rcaballeromx would you please check this PR we would like to include in today's release...

Copy link
Contributor

@rcaballeromx rcaballeromx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made my suggestions to the text. Please change the text to increase consistency and clarity.

@@ -8,10 +8,14 @@ With these files we generated Fedora and Ubuntu packages for this component.

``./update_runtime.sh [VERSION]``

The ``VERSION`` parameter is optional, it can be a tag, a branch or a git hash.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VERSION parameter is optional. The parameter can be a tag, a branch, or a GIT hash.

@@ -8,10 +8,14 @@ With these files we generated Fedora and Ubuntu packages for this component.

``./update_runtime.sh [VERSION]``

The ``VERSION`` parameter is optional, it can be a tag, a branch or a git hash.

If VERSION is not specified, it will be determined automatically from the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the VERSION parameter is not specified, the top-level configure.ac file will determine its value automatically.

This commit adds improvements to the OBS automation tooling for
cc-oci-runtime and updated changelog sent to the OBS builds.

Signed-off-by: Geronimo Orozco <[email protected]>
@gorozco1 gorozco1 force-pushed the obs-cc-oci-runtime-2.1.8 branch from 09e4d8d to eb9d185 Compare May 19, 2017 19:18
@gorozco1
Copy link
Contributor Author

@rcaballeromx thanks for the feedback I updated based on your suggestions.

@rcaballeromx
Copy link
Contributor

@gorozco1 I've reviewed the changes and made suggestions. Let me know as soon as you modify the content to approve it for today's release.

@jcvenegas
Copy link
Contributor

jcvenegas commented May 19, 2017

lgtm

Approved with PullApprove

@jcvenegas jcvenegas merged commit 72d3a59 into intel:master May 19, 2017
@chavafg
Copy link
Contributor

chavafg commented May 19, 2017

qa-passed

@gorozco1 gorozco1 deleted the obs-cc-oci-runtime-2.1.8 branch May 20, 2017 03:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants