-
Notifications
You must be signed in to change notification settings - Fork 59
build: Update cc-oci-runtime obs builds with master #919
Conversation
1966da1
to
2ade9f2
Compare
hi @gorozco1 , I would prefer to merge #911 , because we will need to remove this for next release(tomorrow). We only need approval from @rcaballeromx in #911 |
2ade9f2
to
5b911a2
Compare
qa-passed |
@@ -8,10 +8,14 @@ With these files we generated Fedora and Ubuntu packages for this component. | |||
|
|||
``./update_runtime.sh [VERSION]`` | |||
|
|||
``VERSION`` parameter is optional, it can be a tag, a branch or a git hash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing full-stop. I'd also start this sentence with "The".
``VERSION`` parameter is optional, it can be a tag, a branch or a git hash | ||
|
||
If no ``VERSION`` is specified to the script, it will get it from the one | ||
specified in the ``configure.ac`` file found at the the repository's root. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd simplify and just say something like:
If VERSION
is not specified, it will be determined automatically from the top-level configure.ac
file.
@@ -42,19 +43,23 @@ sed "s/@HASH_TAG@/$hash_tag/g;" update_commit_id.patch-template > update_commit_ | |||
# Update and package OBS | |||
if [ "$OBS_PUSH" = true ] | |||
then | |||
osc co home:clearlinux:preview:clear-containers-staging/cc-oci-runtime | |||
temp=`basename $0` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not actually a problem, but I'd use $( ... )
rather than `...`
as it is much clearer (atleast it is to my eyes ;)
Hi @gorozco1 - could you fix the typo in the commit ("Tis")? |
5b911a2
to
09e4d8d
Compare
@jodh-intel thanks for the feedback all changes you suggested are done |
Thanks @gorozco1. @rcaballeromx - could you review please? lgtm |
qa-passed |
@rcaballeromx would you please check this PR we would like to include in today's release... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made my suggestions to the text. Please change the text to increase consistency and clarity.
@@ -8,10 +8,14 @@ With these files we generated Fedora and Ubuntu packages for this component. | |||
|
|||
``./update_runtime.sh [VERSION]`` | |||
|
|||
The ``VERSION`` parameter is optional, it can be a tag, a branch or a git hash. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The VERSION
parameter is optional. The parameter can be a tag, a branch, or a GIT hash.
@@ -8,10 +8,14 @@ With these files we generated Fedora and Ubuntu packages for this component. | |||
|
|||
``./update_runtime.sh [VERSION]`` | |||
|
|||
The ``VERSION`` parameter is optional, it can be a tag, a branch or a git hash. | |||
|
|||
If VERSION is not specified, it will be determined automatically from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the VERSION
parameter is not specified, the top-level configure.ac
file will determine its value automatically.
This commit adds improvements to the OBS automation tooling for cc-oci-runtime and updated changelog sent to the OBS builds. Signed-off-by: Geronimo Orozco <[email protected]>
09e4d8d
to
eb9d185
Compare
@rcaballeromx thanks for the feedback I updated based on your suggestions. |
@gorozco1 I've reviewed the changes and made suggestions. Let me know as soon as you modify the content to approve it for today's release. |
qa-passed |
Tis commit adds improvements to the OBS automation tooling for cc-oci-runtime, and the updated changelog sent to the OBS builds.
Signed-off-by: Geronimo Orozco [email protected]