Metrics: PSS for a transfer rate of 1Gb #939
Conversation
|
qa-passed |
Makefile.am
Outdated
| @@ -68,6 +68,7 @@ GENERATED_FILES = \ | |||
| tests/metrics/network/network-metrics-cpu-consumption.sh \ | |||
| tests/metrics/network/network-metrics-memory-pss.sh \ | |||
| tests/metrics/network/network-metrics-memory-rss-1g.sh \ | |||
| tests/metrics/network/network-metrics-memory-1g.sh \ | |||
There was a problem hiding this comment.
For consistency with the other two related tests, this really should be called network-metrics-memory-pss-1g.sh :-)
Could you fix that here and below (and obviously rename the source file itself) please.
|
Minor naming nit - would be nice if we can fix that. |
|
@grahamwhaley changes of the name applied |
|
qa-passed |
| @@ -372,6 +373,7 @@ EXTRA_DIST = \ | |||
| tests/metrics/network/network-metrics-cpu-consumption.sh.in \ | |||
| tests/metrics/network/network-metrics-memory-rss-1g.sh.in \ | |||
| tests/metrics/network/network-metrics-memory-pss.sh.in \ | |||
| tests/metrics/network/network-metrics-memory-pss-1g.sh.in \ | |||
There was a problem hiding this comment.
This new test needs to be added to https://github.com/01org/cc-oci-runtime/blob/master/tests/metrics/network/README.md.
There was a problem hiding this comment.
@jodh-intel when #946 is merged then I can add it
There was a problem hiding this comment.
or I can add another PR for the modification of the README
|
I think adding the README mods to this PR as another commit is the best thing - sure, you can wait until #946 is merged (although you might not get a conflict...). I'd hope that will get merged pretty quick, so should not block you. |
|
@jodh-intel changes were applied |
Measure of the proportional set size memory while doing a transfer rate of 1Gb using nuttcp. Signed-off-by: Gabriela Cervantes <[email protected]>
|
lgtm |
|
@iphutch - please could you review the doc changes? |
|
qa-passed |
|
Hi @rcaballeromx, not sure if @iphutch is about so could you review this? |
|
Thanks @iphutch! |
Measure of the proportional set size memory while doing
a transfer rate of 1Gb using nuttcp.
Signed-off-by: Gabriela Cervantes [email protected]