Merge pull request #163 from elbeno/update-clang-tidy

🚨 Update clang-tidy for C++20 checks
intel · Oct 24, 2024 · 3641082 · 3641082
2 parents 5530b5d + fb1b270
commit 3641082
Show file tree

Hide file tree

Showing 16 changed files with 38 additions and 4 deletions.
diff --git a/.github/workflows/asciidoctor-ghpages.yml b/.github/workflows/asciidoctor-ghpages.yml
@@ -35,7 +35,7 @@ jobs:
       - name: Checkout source
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       - name: Setup Node.js
-        uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
+        uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
         with:
           node-version: 20
       - name: Install Mermaid

diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml
@@ -268,7 +268,7 @@ jobs:
           CC: "/usr/lib/llvm-${{env.DEFAULT_LLVM_VERSION}}/bin/clang"
           CXX: "/usr/lib/llvm-${{env.DEFAULT_LLVM_VERSION}}/bin/clang++"
           PR_TARGET_BRANCH: ${{ steps.target_branch.outputs.branch }}
-        run: cmake -B ${{github.workspace}}/build -DCMAKE_CXX_STANDARD=17 -DCPM_SOURCE_CACHE=~/cpm-cache
+        run: cmake -B ${{github.workspace}}/build -DCMAKE_CXX_STANDARD=${{env.DEFAULT_CXX_STANDARD}} -DCPM_SOURCE_CACHE=~/cpm-cache
 
       - name: Save CPM cache
         env:

diff --git a/include/stdx/atomic.hpp b/include/stdx/atomic.hpp
@@ -5,6 +5,7 @@
 #include <atomic>
 #include <type_traits>
 
+// NOLINTBEGIN(cppcoreguidelines-macro-usage)
 #if __cplusplus >= 202002L
 #define CPP20(...) __VA_ARGS__
 #else
@@ -123,3 +124,5 @@ template <typename T> class atomic {
 };
 } // namespace v1
 } // namespace stdx
+
+// NOLINTEND(cppcoreguidelines-macro-usage)
diff --git a/include/stdx/atomic_bitset.hpp b/include/stdx/atomic_bitset.hpp
@@ -50,6 +50,7 @@ class atomic_bitset {
         auto const len = std::min(n, str.size() - pos);
         auto const s = str.substr(pos, std::min(len, N));
         auto i = bit;
+        // NOLINTNEXTLINE(modernize-loop-convert)
         for (auto it = std::rbegin(s); it != std::rend(s); ++it) {
             if (*it == one) {
                 ret |= i;

diff --git a/include/stdx/bit.hpp b/include/stdx/bit.hpp
@@ -13,6 +13,8 @@
 #include <bit>
 #endif
 
+// NOLINTBEGIN(modernize-use-constraints)
+
 namespace stdx {
 inline namespace v1 {
 
@@ -357,3 +359,5 @@ template <std::size_t N> CONSTEVAL auto smallest_uint() {
 template <std::size_t N> using smallest_uint_t = decltype(smallest_uint<N>());
 } // namespace v1
 } // namespace stdx
+
+// NOLINTEND(modernize-use-constraints)
diff --git a/include/stdx/bitset.hpp b/include/stdx/bitset.hpp
@@ -153,6 +153,7 @@ class bitset {
         auto const len = std::min(n, str.size() - pos);
         auto i = std::size_t{};
         auto const s = str.substr(pos, std::min(len, N));
+        // NOLINTNEXTLINE(modernize-loop-convert)
         for (auto it = std::rbegin(s); it != std::rend(s); ++it) {
             set(i++, *it == one);
         }

diff --git a/include/stdx/byterator.hpp b/include/stdx/byterator.hpp
@@ -10,6 +10,8 @@
 #include <iterator>
 #include <type_traits>
 
+// NOLINTBEGIN(modernize-use-constraints)
+
 namespace stdx {
 inline namespace v1 {
 
@@ -210,3 +212,5 @@ byterator(It) -> byterator<detail::iterator_value_t<It>>;
 
 } // namespace v1
 } // namespace stdx
+
+// NOLINTEND(modernize-use-constraints)
diff --git a/include/stdx/ct_string.hpp b/include/stdx/ct_string.hpp
@@ -14,7 +14,7 @@ inline namespace v1 {
 template <std::size_t N> struct ct_string {
     CONSTEVAL ct_string() = default;
 
-    // NOLINTNEXTLINE(*-avoid-c-arrays)
+    // NOLINTNEXTLINE(*-avoid-c-arrays, google-explicit-constructor)
     CONSTEVAL explicit(false) ct_string(char const (&str)[N]) {
         for (auto i = std::size_t{}; i < N; ++i) {
             // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-*)

diff --git a/include/stdx/cx_map.hpp b/include/stdx/cx_map.hpp
@@ -37,6 +37,7 @@ template <typename Key, typename Value, std::size_t N> class cx_map {
 
   public:
     constexpr cx_map() = default;
+    // NOLINTNEXTLINE(modernize-use-constraints)
     template <typename... Vs, std::enable_if_t<((sizeof...(Vs) <= N) and ... and
                                                 stdx::same_as<value_type, Vs>),
                                                int> = 0>

diff --git a/include/stdx/cx_set.hpp b/include/stdx/cx_set.hpp
@@ -24,6 +24,7 @@ template <typename Key, std::size_t N> class cx_set {
 
     constexpr cx_set() = default;
     template <typename... Ts,
+              // NOLINTNEXTLINE(modernize-use-constraints)
               std::enable_if_t<((sizeof...(Ts) <= N) and ... and
                                 stdx::convertible_to<key_type, Ts>),
                                int> = 0>

diff --git a/include/stdx/cx_vector.hpp b/include/stdx/cx_vector.hpp
@@ -31,6 +31,7 @@ template <typename T, std::size_t N> class cx_vector {
 
     constexpr cx_vector() = default;
     template <typename... Ts,
+              // NOLINTNEXTLINE(modernize-use-constraints)
               std::enable_if_t<((sizeof...(Ts) <= N) and ... and
                                 stdx::convertible_to<value_type, Ts>),
                                int> = 0>

diff --git a/include/stdx/optional.hpp b/include/stdx/optional.hpp
@@ -10,6 +10,8 @@
 #include <type_traits>
 #include <utility>
 
+// NOLINTBEGIN(modernize-use-constraints)
+
 namespace stdx {
 inline namespace v1 {
 template <typename T, typename = void> struct tombstone_traits {
@@ -256,3 +258,5 @@ constexpr auto transform(F &&f, Ts &&...ts) {
 }
 } // namespace v1
 } // namespace stdx
+
+// NOLINTEND(modernize-use-constraints)
diff --git a/include/stdx/span.hpp b/include/stdx/span.hpp
@@ -13,6 +13,8 @@
 #include <limits>
 #include <type_traits>
 
+// NOLINTBEGIN(modernize-use-constraints)
+
 namespace stdx {
 inline namespace v1 {
 
@@ -280,3 +282,5 @@ template <typename T, std::size_t N>
 constexpr auto ct_capacity_v<span<T, N>> = N;
 } // namespace v1
 } // namespace stdx
+
+// NOLINTEND(modernize-use-constraints)
diff --git a/include/stdx/type_traits.hpp b/include/stdx/type_traits.hpp
@@ -198,6 +198,7 @@ template <typename T, typename... Ts> constexpr auto try_construct() -> T {
 }
 
 template <typename T> struct any_t {
+    // NOLINTNEXTLINE(modernize-use-constraints)
     template <typename U, std::enable_if_t<not std::is_same_v<T, U>, int> = 0>
     // NOLINTNEXTLINE(google-explicit-constructor)
     constexpr operator U() {

diff --git a/include/stdx/utility.hpp b/include/stdx/utility.hpp
@@ -9,6 +9,8 @@
 #include <type_traits>
 #include <utility>
 
+// NOLINTBEGIN(modernize-use-constraints)
+
 namespace stdx {
 inline namespace v1 {
 
@@ -221,3 +223,4 @@ constexpr auto is_aligned_with = [](auto v) -> bool {
 #endif
 
 // NOLINTEND(cppcoreguidelines-macro-usage)
+// NOLINTEND(modernize-use-constraints)
diff --git a/test/pbt/CMakeLists.txt b/test/pbt/CMakeLists.txt
@@ -1,7 +1,13 @@
 if(${CMAKE_CXX_STANDARD} GREATER_EQUAL 20)
     add_executable(pbt_prototype_driver EXCLUDE_FROM_ALL
                    pbt_prototype_driver.cpp)
-    target_link_libraries(pbt_prototype_driver PUBLIC sanitizers warnings stdx)
+    target_link_libraries(pbt_prototype_driver PRIVATE sanitizers warnings stdx)
+    target_compile_options(
+        pbt_prototype_driver
+        PRIVATE -fconstexpr-depth=4096
+                $<$<CXX_COMPILER_ID:Clang>:-fconstexpr-steps=4000000000>
+                $<$<CXX_COMPILER_ID:GNU>:-fconstexpr-ops-limit=4000000000>
+                $<$<CXX_COMPILER_ID:Clang>:-fbracket-depth=1024>)
 
     add_unit_test(
         tuple