-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(workflows): update long and network tests to Python 3.13 #4779
base: main
Are you sure you want to change the base?
ci(workflows): update long and network tests to Python 3.13 #4779
Conversation
Thank you! I've approved the tests to run and we'll see if there's any surprise problems. |
ooookay. Apparently the branch protection rule requires us to not change the test name, so changing it from 3.10 to 3.13 is leaving me with a required test that can never be completed on this PR. Ugh. Unfortunately, there's a process for me to get admin privileges and fix the rule, so it'll probably take a bit to get that resolved. I'll go get that started, though. |
Ohh okay, do let me know if any help/update is required! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I'm working on that. Can you add 3.10 into the short tests and remove 3.13? Right now this would turn off 3.10 testing entirely, which isn't ideal.
edf0b79
to
9fb766e
Compare
I've updated the short tests to include 3.10 and removed 3.13. Let me know if any further tweaks are needed! |
Looks good, thank you! I've set the tests to run and I'll be back once they're passing, but I think we're good to go unless 3.10 does something weird in the short tests. |
ci: update long and network tests to use Python 3.13
Fixes #4775
Changes:
.github/workflows/testing.yml
to replace Python 3.10 with Python 3.13 in 9 places.Why this change?
Testing & Verification: