Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflows): update long and network tests to Python 3.13 #4779

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JigyasuRajput
Copy link

ci: update long and network tests to use Python 3.13

Fixes #4775

Changes:

Why this change?

  • Python 3.13 has memory optimizations that help mitigate out-of-memory issues in CI.

Testing & Verification:

  • CI should run successfully with the updated version.

@terriko
Copy link
Contributor

terriko commented Feb 7, 2025

Thank you!

I've approved the tests to run and we'll see if there's any surprise problems.

@terriko
Copy link
Contributor

terriko commented Feb 7, 2025

ooookay. Apparently the branch protection rule requires us to not change the test name, so changing it from 3.10 to 3.13 is leaving me with a required test that can never be completed on this PR. Ugh. Unfortunately, there's a process for me to get admin privileges and fix the rule, so it'll probably take a bit to get that resolved. I'll go get that started, though.

@JigyasuRajput
Copy link
Author

ooookay. Apparently the branch protection rule requires us to not change the test name, so changing it from 3.10 to 3.13 is leaving me with a required test that can never be completed on this PR. Ugh. Unfortunately, there's a process for me to get admin privileges and fix the rule, so it'll probably take a bit to get that resolved. I'll go get that started, though.

Ohh okay, do let me know if any help/update is required!

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm working on that. Can you add 3.10 into the short tests and remove 3.13? Right now this would turn off 3.10 testing entirely, which isn't ideal.

@JigyasuRajput JigyasuRajput force-pushed the ci-update-python-3.13-tests-4775 branch from edf0b79 to 9fb766e Compare February 7, 2025 20:50
@JigyasuRajput
Copy link
Author

While I'm working on that. Can you add 3.10 into the short tests and remove 3.13? Right now this would turn off 3.10 testing entirely, which isn't ideal.

I've updated the short tests to include 3.10 and removed 3.13. Let me know if any further tweaks are needed!

@JigyasuRajput JigyasuRajput requested a review from terriko February 7, 2025 21:48
@terriko
Copy link
Contributor

terriko commented Feb 10, 2025

Looks good, thank you! I've set the tests to run and I'll be back once they're passing, but I think we're good to go unless 3.10 does something weird in the short tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: update long and network tests to use python 3.13
2 participants