Skip to content

fix(nvd): handle 'unknown' score value and prevent ValueError #4772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix(nvd): handle 'unknown' score value and prevent ValueError #4772

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5f1dee
fix(nvd): handle 'unknown' score value and prevent ValueError
JigyasuRajput Feb 6, 2025
c71b6d8
fix(nvd): preserve 'unknown' scores and prevent ValueError
JigyasuRajput Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions cve_bin_tool/data_sources/nvd_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,12 +310,15 @@ def format_data_api2(self, all_cve_entries):
)
cve["severity"] = re.sub(r"[\W]", "", cve["severity"])

# score should be numeric
try:
cve["score"] = float(cve["score"])
except ValueError:
self.logger.debug(f"Score for {cve['id']} is invalid: {cve['score']}")
cve["score"] = "invalid"
# score should be numeric, except when score is "unknown"
if cve["score"] != "unknown":
try:
cve["score"] = float(cve["score"])
except ValueError:
self.logger.debug(
f"Score for {cve['id']} is invalid: {cve['score']}"
)
cve["score"] = "invalid"

# CVSS_vector will be validated/normalized when cvss library is used but
# we can at least do a character filter here
Expand Down
Loading