refactor: use Path objects instead of strings #5142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@terriko what do you think? |
rilnicki
force-pushed
the
use-path-objects
branch
from
5221840 to
9f5ea16
Compare
|
@terriko I forgot to run longer tests locally and had to change some things afterwards. |
rilnicki
force-pushed
the
use-path-objects
branch
2 times, most recently
from
0108084 to
1fd509e
Compare
|
I missed one str/Path in one of the test files. It should pass now - three times a charm :) |
Don't convert Paths to Paths. Simplify code and take advantage of Path object methods. Signed-off-by: Rafal Ilnicki <[email protected]>
rilnicki
force-pushed
the
use-path-objects
branch
from
1fd509e to
75bd83b
Compare
|
I added more small changes in tests which seem to not run on CI. |
|
@terriko everything has passed except one unrelated test like the last time, maybe we should change/fix it in another PR? |
|
Pretty sure the last test was fixed with #4929 so it can be ignored! |
|
Great news! Shall I update my branch and then rerun CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't convert Paths to Paths.
Simplify code and take advantage of Path object methods.