feat(parser): add Windows PE parser #5180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ffontaine Thanks for your effort. I closed my PR. As mentioned, I have to discuss vulnerability issue with our cusomter based on the other business tool. If there is any other mismatch, I will port let you know. |
Built from intel#5159, this alternative has the following advantages: - it doesn't create a fake "line" that is passed to binary checker - python binary checker doesn't have to be updated - it allows the end-user to disable this new behavior through "-s pe" - any specific PE handling such as setting the product to lower case or converting "Python Software Foundation" to "python" is done in pe.py For now, pe parser runs only on pyd files but this could be updated. Credits shall be given to @alex-cheng-techman which created most of the original code Signed-off-by: Fabrice Fontaine <[email protected]>
|
Thank you! I need to have a quick think about whether I'm allowed to merge dependency updates now or if I should wait until the repo is moved to openssf and we're clearly not subject to Intel's legal licensing checks. But this generally looks good and like something we want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built from #5159, this alternative has the following advantages:
-s pepe.pyFor now, pe parser runs only on
pydfiles but this could be updated.Credits shall be given to @alex-cheng-techman which created most of the original code