Skip to content

Commit 6ee64d4

Browse files
bcheng0127igcbot
authored andcommitted
Changes in code.
1 parent 5b342d0 commit 6ee64d4

File tree

4 files changed

+3
-24
lines changed

4 files changed

+3
-24
lines changed

IGC/ocloc_tests/optimizations/PromoteToPredicatedMemoryAccess/LoadSubDW.cl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ SPDX-License-Identifier: MIT
1313
// RUN: ocloc compile -file %s -device pvc -options "-igc_opts 'EnablePromoteToPredicatedMemoryAccess=1 VISAOptions=-asmToConsole'" 2>&1 | FileCheck %s --check-prefixes=CHECK-ASM
1414

1515
// CHECK-ASM: kernel test_i8_0
16+
// CHECK-ASM: cmp (32|M0) (lt)[[F1:f[0-9\.]+]]
17+
// CHECK-ASM: ([[F1]]) goto (32|M0)
1618
// CHECK-ASM: {{[_a-z0-9A-Z]+}}:
1719
// CHECK-ASM-DAG: cmp (32|M0) (le)[[F2:f[0-9\.]+]] null<1>:d r{{[0-9\.]+}}
1820
// CHECK-ASM-DAG: cmp (32|M0) (ge)[[F3:f[0-9\.]+]] null<1>:d r{{[0-9\.]+}}

visa/LocalScheduler/Dependencies_G4IR.cpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -189,15 +189,6 @@ DepType vISA::getDepScratchSend(G4_INST *curInst, G4_INST *liveInst) {
189189
return NODEP;
190190
}
191191

192-
bool vISA::isNotLatencyBarrier (DepType type) {
193-
if (type == CONTROL_FLOW_BARRIER ||
194-
type == OPT_BARRIER ||
195-
type == SEND_BARRIER ||
196-
type == MSG_BARRIER)
197-
return true;
198-
return false;
199-
}
200-
201192
DepType vISA::CheckBarrier(G4_INST *inst) {
202193
if (inst->isOptBarrier() || inst->isAtomicInst() || inst->opcode() == G4_madm) {
203194
return OPT_BARRIER;

visa/LocalScheduler/Dependencies_G4IR.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ DepType getDepSend(G4_INST *curInst, G4_INST *liveInst, bool BTIIsRestrict);
3838

3939
DepType getDepScratchSend(G4_INST *curInst, G4_INST *liveInst);
4040

41-
bool isNotLatencyBarrier(DepType type);
42-
4341
DepType CheckBarrier(G4_INST *inst);
4442

4543
DepType getDepForOpnd(Gen4_Operand_Number cur, Gen4_Operand_Number liv);

visa/LocalScheduler/LocalScheduler_G4IR.cpp

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1887,21 +1887,9 @@ void DDD::collectRoots() {
18871887
void DDD::setPriority(Node *pred, const Edge &edge) {
18881888
// Calculate PRED's priority (pred->priority), based on SUCC's priority
18891889
Node *succ = edge.getNode();
1890-
DepType type = edge.getType();
18911890
vISA_ASSERT(succ->priority != Node::PRIORITY_UNINIT,
18921891
"succ node has no priority?");
1893-
int newPriority = succ->priority;
1894-
// Note that, node->isBarrier cannot be used here. Because there may be
1895-
// non-barrier dep.
1896-
bool isSend = false;
1897-
if (!pred->getInstructions()->empty()) {
1898-
isSend = pred->getInstructions()->front()->isSend();
1899-
}
1900-
if (isNotLatencyBarrier(type) &&
1901-
!isSend) // send has long latency, it's better be scheduled to the front.
1902-
newPriority += pred->getOccupancy();
1903-
else
1904-
newPriority += edge.getLatency();
1892+
int newPriority = succ->priority + edge.getLatency();
19051893
pred->priority =
19061894
(newPriority > pred->priority) ? newPriority : pred->priority;
19071895
}

0 commit comments

Comments
 (0)