-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAISE-BP] Remove mask for pointer tensor load/store operations #1636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. Should we then fail if we find a mask on tt.load/store
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it safe to simply remove mask from load and store?
You're right. It not safe to simply remove mask. Issue #1784 has been created to address this problem. |
Do we still need to review this PR? Should it be closed? |
The changes in this PR are still needed as block pointer load/store ops are not in line with the triton ops spec. |
Subsequent lowering passes don't expect pointer tensor load/store operations to have a non-null mask operand.
This PR therefore remove the mask operand from the generated load/store operations.
If a load/store operation has a non-empty mask, the operation is not rewritten.
This PR also improve the robustness of the pass by adding a cast operation if
size
,shape
oroffset
values ofMakeTensorPtrOp
are of typeIndex
.