Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFI] Change LLVM_CONFIG setting position #2034

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

whitneywhtsang
Copy link
Contributor

No description provided.

@whitneywhtsang
Copy link
Contributor Author

@AshburnLee Can you please verify if it still works as expected with this change?
We haven't get PR to update the translator for a while, is it reenabled from last time?

@whitneywhtsang whitneywhtsang linked an issue Aug 28, 2024 that may be closed by this pull request
@AshburnLee
Copy link
Contributor

@AshburnLee Can you please verify if it still works as expected with this change? We haven't get PR to update the translator for a while, is it reenabled from last time?

Sure, I'll check
It's still disabled because I'm not sure if Triton now supports llvm-20

@AshburnLee
Copy link
Contributor

AshburnLee commented Aug 29, 2024

BTW, I tried with newer Translator cid, both form local and Action(https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/10608591640/job/29402931726), I got the same result:

      CMake Error at cmake/FindLLVM.cmake:63 (message):
        Unsupported LLVM version 19.0.0git found
        (/home/jovyan/workspace/packages/llvm/lib/../bin/llvm-config).  At least
        version 20.0.0 is required.  You can also set variables 'LLVM_ROOT_DIR' or
        'LLVM_CONFIG' to use a different LLVM installation.

I also reinstalled LLVM and same result, Probably it's because the cid in cmake/llvm-hash.txt is still for 19.

Anyway, I enabled nighly Translator check and update

@whitneywhtsang
Copy link
Contributor Author

You are right, LLVM commit hasn't been updated for a while.

@whitneywhtsang whitneywhtsang merged commit d7c1c27 into llvm-target Aug 29, 2024
4 checks passed
@whitneywhtsang whitneywhtsang deleted the whitneywhtsang/spirv branch August 29, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimize difference between Intel port and OpenAI Triton
3 participants