Setup MSVC environment in CI workflow #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
changed the title
CLFinder.py in setup.py
anmyachev
requested review from
gshimansky and
pbchekin
and removed request for
gshimansky
gshimansky
approved these changes
Dec 6, 2024
pbchekin
reviewed
Dec 6, 2024
Comment on lines
+49
to
+53
| cmd /c '"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x64 && set' | ForEach-Object { | ||
| if ($_ -match '^(.*?)=(.*)$') { | ||
| [Environment]::SetEnvironmentVariable($matches[1], $matches[2]) | ||
| } | ||
| } |
There was a problem hiding this comment.
This should also work (and simpler).
Suggested change
| cmd /c '"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x64 && set' | ForEach-Object { | |
| if ($_ -match '^(.*?)=(.*)$') { | |
| [Environment]::SetEnvironmentVariable($matches[1], $matches[2]) | |
| } | |
| } | |
| Invoke-BatchFile "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" |
There was a problem hiding this comment.
Invoke-BatchFile is a non-standard extension which is not installed by default. I actually like that Anatoly found a solution that doesn't require installing it, we may want to use it instead. Also save environment variables into GITHUB_ENV for further steps.
There was a problem hiding this comment.
We install a lot of custom stuff to the runner image, including support for Invoke-BatchFile.
There was a problem hiding this comment.
I've rolled back the last changes and am going to merge the version that was approved. Feel free to ask me to finish something, I can do it in a separate pull request.
Co-authored-by: Pavel Chekin <[email protected]>
anmyachev
commented
Dec 6, 2024
anmyachev
added a commit
that referenced
this pull request
Dec 7, 2024
Part of #2030 Part of #2824 For all other compilers the situation is about the same, it is expected that they are already in the paths. I don't think it should be any different for Windows. --------- Signed-off-by: Anatoly Myachev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2030
Part of #2824
For all other compilers the situation is about the same, it is expected that they are already in the paths. I don't think it should be any different for Windows.