-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Implement sycl_ext_oneapi_if_device #10169
Conversation
So that we could start removing |
Specification PR is at intel#8917.
c20a18f
to
4006375
Compare
// RUN: %{build} -o %t.out | ||
// RUN: %{run} %t.out | ||
|
||
#include <sycl/sycl.hpp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, include minimal required set of headers: queue, buffer, accessor and <sycl/ext/oneapi/experimental/if_device.hpp>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly disagree. The right process to do that is to update the spec/create extension, allocate resources to the activity, cleanup the headers and create automation/checks to automatically cleanup includes and only after that can we start requesting such changes in arbitrary PRs. Until then we have to treat end-to-end tests same way as examples and write them how customers would write their code according to the specification.
Failures:
covered by and the last is mentioned/awaiting followup in #10173 (comment). |
@aelovikov-intel, this seems to be ready to merge. What is holding this back? |
Actually, this should not be merged yet. There was a recent change in the API, and the |
Converted to draft. Please, convert back when it's ready to go forward. |
Specification PR is at #8917.