Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Implement sycl_ext_oneapi_if_device #10169

Closed
wants to merge 2 commits into from

Conversation

aelovikov-intel
Copy link
Contributor

Specification PR is at #8917.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner June 30, 2023 19:42
@aelovikov-intel
Copy link
Contributor Author

So that we could start removing __SYCL_DEVICE_ONLY__ from the SYCL headers.

@aelovikov-intel aelovikov-intel temporarily deployed to aws June 30, 2023 20:29 — with GitHub Actions Inactive
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

#include <sycl/sycl.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, include minimal required set of headers: queue, buffer, accessor and <sycl/ext/oneapi/experimental/if_device.hpp>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly disagree. The right process to do that is to update the spec/create extension, allocate resources to the activity, cleanup the headers and create automation/checks to automatically cleanup includes and only after that can we start requesting such changes in arbitrary PRs. Until then we have to treat end-to-end tests same way as examples and write them how customers would write their code according to the specification.

@aelovikov-intel aelovikov-intel temporarily deployed to aws June 30, 2023 22:35 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel requested a review from bader July 5, 2023 15:43
@aelovikov-intel aelovikov-intel temporarily deployed to aws July 5, 2023 17:36 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel temporarily deployed to aws July 5, 2023 18:58 — with GitHub Actions Inactive
@aelovikov-intel
Copy link
Contributor Author

Failures:

# Intel:
Failed Tests (1):
SYCL :: ESIMD/accessor_local.cpp

# HIP:
Failed Tests (4):
  SYCL :: USM/memops2d/copy2d_device_to_host.cpp
  SYCL :: USM/memops2d/copy2d_host_to_device.cpp
  SYCL :: USM/memops2d/memcpy2d_device_to_host.cpp
  SYCL :: USM/memops2d/memcpy2d_host_to_device.cpp

# CUDA:
Unexpectedly Passed Tests (1):
  SYCL :: DeviceArchitecture/device_architecture_on_host.cpp

covered by

#10138
#10157

and the last is mentioned/awaiting followup in #10173 (comment).

@bader
Copy link
Contributor

bader commented Sep 12, 2023

@aelovikov-intel, this seems to be ready to merge. What is holding this back?

@gmlueck
Copy link
Contributor

gmlueck commented Sep 12, 2023

Actually, this should not be merged yet. There was a recent change in the API, and the fn parameter is now passed via perfect forwarding (i.e. as T &&Fn). See #8917.

@gmlueck gmlueck self-requested a review September 12, 2023 12:19
@bader bader marked this pull request as draft September 12, 2023 14:29
@bader
Copy link
Contributor

bader commented Sep 12, 2023

Actually, this should not be merged yet.

Converted to draft. Please, convert back when it's ready to go forward.

@bader bader removed their request for review September 16, 2023 01:14
@aelovikov-intel aelovikov-intel deleted the if-device branch September 12, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants