[SYCL][DOC] Add ext_intel_virtual_functions specification #10540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ual-functions-extension-spec
…roduce new macro for indirectly_callable property
…ual-functions-extension-spec
AlexeySachkov
added a commit
that referenced
this pull request
Jul 22, 2024
With `sycl_ext_oneapi_virtual_functions` extensions we would like to allow certain kernels to perform virtual function calls. That is if they were submitted with the right properties. That means that instead of simply checking for presence of virtual function calls in device code, we need to analyze call chain to see how exactly a kernel performing such call is defined. This is not a task for the front-end and therefore the diagnostics mechanism is moved to a pass, as suggested by the implementation design proposed in #10540
…ual-functions-extension-spec
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
added a commit
that referenced
this pull request
Jul 25, 2024
Test plan can be found in #10540. This PR introduces a basic test case for a scenario where object of a polymorphic class is constructed in one kernel, but used in another kernel.
hdelan
pushed a commit
to hdelan/llvm
that referenced
this pull request
Jul 26, 2024
Test plan can be found in intel#10540. This PR introduces a basic test case for a scenario where object of a polymorphic class is constructed in one kernel, but used in another kernel.
AlexeySachkov
added a commit
that referenced
this pull request
Aug 5, 2024
Implementation design explaining those changes in a bigger picture can be found in #10540 Key things implemented here: - device code split to outline virtual functions into separate device images - emission of new properties for virtual functions - generation of `calls-indirectly` LLVM IR attribute for kernels that construct objects with virtual functions, but don't do calls - device image manipulations to cleanup or preserve virtual functions depending on a device image Even though those pieces are technically independent from each other, it is hard to split them apart into separate PRs, because they all have to be either present or absent for existing E2E tests for virtual functions to work.
AlexeySachkov
added a commit
to AlexeySachkov/llvm
that referenced
this pull request
Aug 7, 2024
Corresponding SYCL extension proposal (intel#10540) has been recently updated to change naming of properties it introduces. This patch aligns the implementation with the proposed extension spec.
AlexeySachkov
added a commit
that referenced
this pull request
Aug 9, 2024
Corresponding SYCL extension proposal (#10540) has been recently updated to change naming of properties it introduces. This patch aligns the implementation with the proposed extension spec.
| functions they may call, the extension introduces new compile-time-constant | ||
| properties. | ||
|
|
||
| [source,dpcpp] |
There was a problem hiding this comment.
May these "[source,dpcpp]" be changed to "```c++"? Otherwise, the syntax is not highlighted.
| }; | ||
|
|
||
| struct calls_indirectly_key { | ||
| template <typename First, typename... SetIds> |
There was a problem hiding this comment.
As discussed offline - typename First likely can be omitted.
KornevNikita
added a commit
to KornevNikita/llvm
that referenced
this pull request
Sep 26, 2024
This allows calls_indirectly property to handle all passed template arguments, but not the only first one. Also applying some minor changes to the spec. Spec & Design: intel#10540
AlexeySachkov
pushed a commit
that referenced
this pull request
Oct 1, 2024
This allows calls_indirectly property to handle all passed template arguments, but not the only first one. Also applying some minor changes to the spec. Spec & Design: #10540
KornevNikita
added a commit
to KornevNikita/llvm
that referenced
this pull request
Oct 2, 2024
AlexeySachkov
pushed a commit
that referenced
this pull request
Oct 10, 2024
AlexeySachkov
pushed a commit
that referenced
this pull request
Nov 6, 2024
AlexeySachkov
added a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
Corresponding SYCL extension proposal (intel#10540) has been recently updated to change naming of properties it introduces. This patch aligns the implementation with the proposed extension spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.