-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Implement sycl_ext_oneapi_group_load_store #10694
base: sycl
Are you sure you want to change the base?
Conversation
Tagging @steffenlarsen @Pennycook @aelizaro |
@ykhatav You've mentioned in the description that this is a continuation of work from Andrei's PR, could you please also specify Andrei as the co-author like this: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors or another way is to change author of the first commit (I assume it was taken from his PR) - it can be done using interactive rebase and git commit --amend --author "Andrei Elovikov [email protected]" and then force push. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me from API point of view, thank you! *but I am definitely not an effective implementation expert
accessor acc{b, cgh}; | ||
accessor res{result, cgh}; | ||
|
||
static constexpr auto scratch_mem_per_wi = ELEMS_PER_WI * sizeof(MemType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will we implement template<typename T, std::size_t ElementsPerWorkItem> constexpr std::size_t memory_required(sycl::memory_scope scope, std::size_t block_size);
function or is too uncertain how to use it? (I assume such function might appear in other proposals as well)
llvm/sycl/doc/extensions/proposed/sycl_ext_oneapi_group_load_store_extended.asciidoc
Line 190 in ec562fc
constexpr std::size_t memory_required(sycl::memory_scope scope, |
Continuing the work in #9074 here.