Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Implement sycl_ext_oneapi_group_load_store #10694

Open
wants to merge 8 commits into
base: sycl
Choose a base branch
from

Conversation

ykhatav
Copy link
Contributor

@ykhatav ykhatav commented Aug 4, 2023

Continuing the work in #9074 here.

@ykhatav ykhatav temporarily deployed to aws August 4, 2023 17:15 — with GitHub Actions Inactive
@ykhatav ykhatav marked this pull request as ready for review August 4, 2023 17:27
@ykhatav ykhatav requested a review from a team as a code owner August 4, 2023 17:27
@ykhatav ykhatav requested a review from aelovikov-intel August 4, 2023 17:27
@ykhatav
Copy link
Contributor Author

ykhatav commented Aug 4, 2023

Tagging @steffenlarsen @Pennycook @aelizaro

@againull
Copy link
Contributor

againull commented Aug 10, 2023

@ykhatav You've mentioned in the description that this is a continuation of work from Andrei's PR, could you please also specify Andrei as the co-author like this: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors or another way is to change author of the first commit (I assume it was taken from his PR) - it can be done using interactive rebase and git commit --amend --author "Andrei Elovikov [email protected]" and then force push.

Copy link
Contributor

@aelizaro aelizaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from API point of view, thank you! *but I am definitely not an effective implementation expert

accessor acc{b, cgh};
accessor res{result, cgh};

static constexpr auto scratch_mem_per_wi = ELEMS_PER_WI * sizeof(MemType);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will we implement template<typename T, std::size_t ElementsPerWorkItem> constexpr std::size_t memory_required(sycl::memory_scope scope, std::size_t block_size); function or is too uncertain how to use it? (I assume such function might appear in other proposals as well)

constexpr std::size_t memory_required(sycl::memory_scope scope,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants