-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][E2E][Joint Matrix] Add half colmajor A colmajor B test #16683
Conversation
YuriPlyakhin
commented
Jan 18, 2025
- Add test for half colmajor A, colmajor B load for 8x16x16
- Refactor to get rid of unnecessary SG32-specific file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you deleted the SG32 test. How are we testing SG32 for this test as 2d load additions for SG32 should take care of transpose/VNNI for this test?
Please, check the top of the .cpp file. I'm building and running it 2 times, we don't need to keep SG32 folder to test sub-group size 32:
SG32 with transpose/VNNI can be implemented with or without 2d block load/store. SYCL E2E test doesn't control such implementation detail. Currently SG32 implementation with transpose doesn't use 2d block load, but test will pass. not related to your question: |
- Add test for half colmajor A, colmajor B load for 8x16x16 - Refactor to get rid of unnecessary SG32-specific file
65c4ba0
to
1ec8bc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@intel/llvm-gatekeepers , failure is not related. Please, merge. Failed Tests (1): I submitted #16774 |