Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E][Joint Matrix] Add half colmajor A colmajor B test #16683

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

YuriPlyakhin
Copy link
Contributor

  • Add test for half colmajor A, colmajor B load for 8x16x16
  • Refactor to get rid of unnecessary SG32-specific file

Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you deleted the SG32 test. How are we testing SG32 for this test as 2d load additions for SG32 should take care of transpose/VNNI for this test?

@YuriPlyakhin
Copy link
Contributor Author

YuriPlyakhin commented Jan 24, 2025

I see you deleted the SG32 test. How are we testing SG32 for this test

Please, check the top of the .cpp file. I'm building and running it 2 times, we don't need to keep SG32 folder to test sub-group size 32:

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
// RUN: %{build} -o %t32.out -DSG_SZ=32
// RUN: %{run} %t32.out

as 2d load additions for SG32 should take care of transpose/VNNI for this test?

SG32 with transpose/VNNI can be implemented with or without 2d block load/store. SYCL E2E test doesn't control such implementation detail. Currently SG32 implementation with transpose doesn't use 2d block load, but test will pass.

not related to your question:
I will need to update this PR due to test folders restructuring.

- Add test for half colmajor A, colmajor B load for 8x16x16
- Refactor to get rid of unnecessary SG32-specific file
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuriPlyakhin
Copy link
Contributor Author

YuriPlyakhin commented Jan 24, 2025

@intel/llvm-gatekeepers , failure is not related. Please, merge.

Failed Tests (1):
SYCL :: Adapters/enqueue-arg-order-buffer.cpp

I submitted #16774

@martygrant martygrant merged commit 3ff6428 into intel:sycl Jan 27, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants