-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Graph] Add common reference semantics #16788
Open
fabiomestre
wants to merge
5
commits into
intel:sycl
Choose a base branch
from
reble:fabio/common_reference_semantics
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+333
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiomestre
had a problem deploying
to
WindowsCILock
January 27, 2025 14:17 — with
GitHub Actions
Failure
fabiomestre
force-pushed
the
fabio/common_reference_semantics
branch
from
January 27, 2025 14:26
d1ac215
to
8a2571d
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
January 27, 2025 14:26 — with
GitHub Actions
Error
fabiomestre
force-pushed
the
fabio/common_reference_semantics
branch
from
January 27, 2025 14:27
8a2571d
to
e786630
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
January 27, 2025 14:28 — with
GitHub Actions
Error
fabiomestre
force-pushed
the
fabio/common_reference_semantics
branch
from
January 27, 2025 14:41
e786630
to
c547e3f
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
January 27, 2025 14:42 — with
GitHub Actions
Failure
fabiomestre
temporarily deployed
to
WindowsCILock
January 27, 2025 15:17 — with
GitHub Actions
Inactive
fabiomestre
had a problem deploying
to
WindowsCILock
January 27, 2025 17:41 — with
GitHub Actions
Failure
Bensuo
reviewed
Jan 27, 2025
fabiomestre
had a problem deploying
to
WindowsCILock
January 27, 2025 19:15 — with
GitHub Actions
Failure
EwanC
reviewed
Jan 28, 2025
sycl/unittests/Extensions/CommandGraph/CommonReferenceSemantics.cpp
Outdated
Show resolved
Hide resolved
sycl/unittests/Extensions/CommandGraph/CommonReferenceSemantics.cpp
Outdated
Show resolved
Hide resolved
sycl/unittests/Extensions/CommandGraph/CommonReferenceSemantics.cpp
Outdated
Show resolved
Hide resolved
EwanC
changed the title
Add common reference semantics to sycl graphs
[SYCL][Graph] Add common reference semantics
Jan 28, 2025
Adds missing common reference semantic functionality such as operator==, operator!= and hash functions to all sycl graph related classes.
fabiomestre
force-pushed
the
fabio/common_reference_semantics
branch
from
January 29, 2025 15:24
1db12ad
to
8c9c0ea
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
January 29, 2025 15:26 — with
GitHub Actions
Error
fabiomestre
temporarily deployed
to
WindowsCILock
January 29, 2025 15:28 — with
GitHub Actions
Inactive
fabiomestre
temporarily deployed
to
WindowsCILock
January 29, 2025 16:19 — with
GitHub Actions
Inactive
@intel/llvm-reviewers-runtime Could someone have a look at the change in this PR? |
Bensuo
reviewed
Jan 31, 2025
fabiomestre
temporarily deployed
to
WindowsCILock
January 31, 2025 15:01 — with
GitHub Actions
Inactive
Bensuo
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
fabiomestre
temporarily deployed
to
WindowsCILock
January 31, 2025 15:49 — with
GitHub Actions
Inactive
cperkinsintel
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing common reference semantic functionality such as operator==, operator!= and hash functions to all sycl graph related classes.