Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph] Add common reference semantics #16788

Open
wants to merge 5 commits into
base: sycl
Choose a base branch
from

Conversation

fabiomestre
Copy link
Contributor

Adds missing common reference semantic functionality such as operator==, operator!= and hash functions to all sycl graph related classes.

@fabiomestre fabiomestre force-pushed the fabio/common_reference_semantics branch from d1ac215 to 8a2571d Compare January 27, 2025 14:26
@fabiomestre fabiomestre force-pushed the fabio/common_reference_semantics branch from 8a2571d to e786630 Compare January 27, 2025 14:27
@fabiomestre fabiomestre marked this pull request as ready for review January 27, 2025 14:37
@fabiomestre fabiomestre requested a review from a team as a code owner January 27, 2025 14:37
@fabiomestre fabiomestre requested a review from Bensuo January 27, 2025 14:37
@fabiomestre fabiomestre force-pushed the fabio/common_reference_semantics branch from e786630 to c547e3f Compare January 27, 2025 14:41
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/ext/oneapi/experimental/graph.hpp Outdated Show resolved Hide resolved
@EwanC EwanC changed the title Add common reference semantics to sycl graphs [SYCL][Graph] Add common reference semantics Jan 28, 2025
@fabiomestre fabiomestre requested a review from a team as a code owner January 29, 2025 14:42
Adds missing common reference semantic functionality such
as operator==, operator!= and hash functions to all
sycl graph related classes.
@fabiomestre fabiomestre force-pushed the fabio/common_reference_semantics branch from 1db12ad to 8c9c0ea Compare January 29, 2025 15:24
@fabiomestre
Copy link
Contributor Author

@intel/llvm-reviewers-runtime Could someone have a look at the change in this PR?

Copy link
Contributor

@Bensuo Bensuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants