[ClangLinkerWrapper] Reintroduce missing upstream commits that remove in-house LTO in clang-linker-wrapper #16952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asudarsa
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
asudarsa
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@AlexeySachkov, please, take a look. This seems to duplicate/conflict with #16926. |
…159d95ca6d0823ea Signed-off-by: Arvind Sudarsanam <[email protected]>
asudarsa
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Hi @bader I had an offline discussion with @AlexeySachkov and we decided to have a separate PR for bringing in missing upstream commits and do improvements in a separate PR. Thanks |
asudarsa
commented
Feb 10, 2025
| @@ -285,15 +282,17 @@ Expected<StringRef> createOutputFile(const Twine &Prefix, StringRef Extension) { | |||
| return TempFiles.back(); | |||
| } | |||
|
|
|||
| Expected<StringRef> writeOffloadFile(const OffloadFile &File) { | |||
| // TODO: Remove HasSYCLOffloadKind dependence when aligning with community code. | |||
There was a problem hiding this comment.
When we start using clang-sycl-linker, we can remove dependence on HasSYCLOffloadKind here.
Thanks
asudarsa
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
mdtoguchi
approved these changes
Feb 10, 2025
Signed-off-by: Arvind Sudarsanam <[email protected]>
asudarsa
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
|
Some changes that overlapped with changes in #16884 have been removed from this PR. Thanks |
Signed-off-by: Arvind Sudarsanam <[email protected]>
asudarsa
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
asudarsa
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of upstream commits were not merged due to merge conflicts.
This PR reintroduces the following upstream commits:
Also, This PR restores missing changes from upstream commit aae059e1389bebe86ceb3aea159d95ca6d0823ea](f2f1a14)
Thanks