Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC][libclc] remove redundant unary_intrin.inc #16958

Conversation

wenju-he
Copy link
Contributor

generic/include/math/unary_intrin.inc is moved into clc folder in 293c78b. However, merge commit c5025ac adds the file back to generic folder.

generic/include/math/unary_intrin.inc is moved into clc folder in
293c78b. However, merge commit c5025ac adds the file back to
generic folder.
@wenju-he wenju-he requested a review from a team as a code owner February 11, 2025 07:55
@wenju-he wenju-he requested a review from Seanst98 February 11, 2025 07:55
Copy link
Contributor

@frasercrmck frasercrmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up!

@wenju-he
Copy link
Contributor Author

@intel/llvm-gatekeepers please merge, thanks.

ESIMD/named_barriers/loop.cpp fail is known unrelated issue: #16598

********************
Failed Tests (1):
  SYCL :: ESIMD/named_barriers/loop.cpp

@aelovikov-intel
Copy link
Contributor

@intel/llvm-gatekeepers please merge, thanks.

ESIMD/named_barriers/loop.cpp fail is known unrelated issue: #16598

********************
Failed Tests (1):
  SYCL :: ESIMD/named_barriers/loop.cpp

Not cool omitting other failures from your CI job:

********************
Timed Out Tests (1):
  SYCL :: Graph/RecordReplay/multiple_exec_graphs.cpp   // <<<< This one

********************
Failed Tests (1):
  SYCL :: ESIMD/named_barriers/loop.cpp

@wenju-he
Copy link
Contributor Author


Timed Out Tests (1):
SYCL :: Graph/RecordReplay/multiple_exec_graphs.cpp // <<<< This one

Thanks @aelovikov-intel, I missed the fail. Re-run the pre-commit testing show the test passes. So it is flaky and is tracked in #16949

@intel/llvm-gatekeepers please merge this pr, thanks.

@aelovikov-intel aelovikov-intel merged commit 410bd24 into intel:sycl Feb 13, 2025
15 of 16 checks passed
@wenju-he wenju-he deleted the fix-merge-conflict-resolve-c5025ac04db7-libclc-unary_intrin.inc branch February 13, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants