Skip to content

[UR][L0 v2] Do not use logger::error in queue dtor #18181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

igchor
Copy link
Member

@igchor igchor commented Apr 24, 2025

The logger might throw leading to an abort.

The error message will be printed anyway if the PrintTrace is set.

@igchor igchor requested a review from a team as a code owner April 24, 2025 15:52
@igchor igchor temporarily deployed to WindowsCILock April 24, 2025 15:53 — with GitHub Actions Inactive
The logger might throw leading to an abort.

The error message will be printed anyway if the PrintTrace
is set.
@igchor
Copy link
Member Author

igchor commented Apr 25, 2025

@intel/llvm-gatekeepers this is ready to be merged

@sarnex sarnex merged commit 6194b94 into intel:sycl Apr 25, 2025
33 checks passed
@igchor igchor deleted the fix_exception_queue branch April 25, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants