Skip to content

[Test] Seemed to pass CI in this form, need to verify #18189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Draft

[Test] Seemed to pass CI in this form, need to verify #18189

wants to merge 1 commit into from

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

@aelovikov-intel
[NFCI][SYCL] Less shared_ptr for platform_impl
516ca32 
`GlobalHandler::MPlatformCache` keeps (shared) ownership of
`platform_impl` objects, so none of them could be destroyed until SYCL
RT library shutdown/unload process. As such, using raw
pointers/reference to `platform_impl` throughout the SYCL RT is totally
fine and avoids extra costs of `std::shared_ptr`

I'm relatively sure `sycl::platform` could avoid using
`std::shared_ptr<detail::platform_impl> impl` as well, but that would be
a breaking change so not being implemented at this moment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aelovikov-intel