[Driver][SYCL] Remove object upon failure #18190
Open
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typical behaviors when the compilation fails is to have the resulting output object to be removed. Due to the fact that there are multiple compilations that occur during an offload compilation, the actual final output object may not be directly associated with the compile causing it to not be removed. Update the cleanup file list to remove the output result file regardless of the associated job action when we are performing offload. Signed-off-by: Michael D Toguchi <[email protected]>
Signed-off-by: Michael D Toguchi <[email protected]>
mdtoguchi
force-pushed
the
remove-file-on-fail
branch
from
362ae2b to
eaa113d
Compare
hchilama
approved these changes
Apr 25, 2025
| @@ -2708,7 +2708,11 @@ int Driver::ExecuteCompilation( | |||
| // Remove result files if we're not saving temps. | |||
| if (!isSaveTempsEnabled()) { | |||
| const JobAction *JA = cast<JobAction>(&FailingCommand->getSource()); | |||
| C.CleanupFileMap(C.getResultFiles(), JA, true); | |||
| // When performing offload compilations, the result files may not match | |||
| // the JobAction that fails. In that case, do not pass in the JobAction | |||
There was a problem hiding this comment.
// When performing offload compilations, the result files may not match the JobAction that fails.
Can you add some details on why they don't match?
And also give an example Offload JobAction for this scenario?
| // REQUIRES: system-linux | ||
|
|
||
| // RUN: touch %t.o | ||
| // RUN: not %clangxx -fsycl -Xsycl-target-frontend -DCOMPILE_HOST_FAIL=1 -o %t.o %s |
There was a problem hiding this comment.
I'm not sure I understand this test. Could you please elaborate?
I think you are creating a new object file.
And triggering a host compilation failure.
And the expectation is that the object file created gets removed?
The test description mentions, Verify object removal when the offload compilation fails , but you are triggering a host compilation failure.
Can you trigger any offload compilation action failure instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typical behaviors when the compilation fails is to have the resulting output object to be removed. Due to the fact that there are multiple compilations that occur during an offload compilation, the actual final output object may not be directly associated with the compile causing it to not be removed.
Update the cleanup file list to remove the output result file regardless of the associated job action when we are performing offload.