[SYCL] Allow __glibcxx_assert_fail in SemaSYCL #18856
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
yingcong-wu
reviewed
Jun 9, 2025
Comment on lines
+615
to
+626
| if (IsAllowed) | ||
| return true; | ||
|
|
||
| // GCC-15 introduced "std::__glibcxx_assert_fail" declared c++config.h and | ||
| // extensively used in STL to do runtime check in debug mode. The behavior | ||
| // is similar to "assert", we have supported it in libdevice in the same way | ||
| // as "assert". However, Sema check will report "undefined function without | ||
| // SYCL_EXTERNAL attribute" error in some cases. We have to allow it just as | ||
| // what we did to "__failed_assertion". The prototype is following: | ||
| // void __glibcxx_assert_fail(const char *, int, const char *, const char*); | ||
| IsAllowed = (Callee->getName() == GlibcxxAssertFail) && | ||
| Callee->getNumParams() == 4 && |
There was a problem hiding this comment.
Suggested change
| if (IsAllowed) | |
| return true; | |
| // GCC-15 introduced "std::__glibcxx_assert_fail" declared c++config.h and | |
| // extensively used in STL to do runtime check in debug mode. The behavior | |
| // is similar to "assert", we have supported it in libdevice in the same way | |
| // as "assert". However, Sema check will report "undefined function without | |
| // SYCL_EXTERNAL attribute" error in some cases. We have to allow it just as | |
| // what we did to "__failed_assertion". The prototype is following: | |
| // void __glibcxx_assert_fail(const char *, int, const char *, const char*); | |
| IsAllowed = (Callee->getName() == GlibcxxAssertFail) && | |
| Callee->getNumParams() == 4 && | |
| // GCC-15 introduced "std::__glibcxx_assert_fail" declared c++config.h and | |
| // extensively used in STL to do runtime check in debug mode. The behavior | |
| // is similar to "assert", we have supported it in libdevice in the same way | |
| // as "assert". However, Sema check will report "undefined function without | |
| // SYCL_EXTERNAL attribute" error in some cases. We have to allow it just as | |
| // what we did to "__failed_assertion". The prototype is following: | |
| // void __glibcxx_assert_fail(const char *, int, const char *, const char*); | |
| IsAllowed = IsAllowed || (Callee->getName() == GlibcxxAssertFail) && | |
| Callee->getNumParams() == 4 && |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC-15 introduced __glibcxx_assert_fail function used in -O0 for many STL functions' runtime check. Its behavior is similar to normal 'assert', so we have supported it in libdevice in the same way as 'assert'. However, compfail will happen in some scenario reporting "undefined function without SYCL_EXTERNAL" error for "__glibcxx_assert_fail" declared in c++config.h, we have to allow this as exception in SemaSYCL.