[NFCI][SYCL] Change device_image_impl::MDevices to store raw device_impl *
#19459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
commented
Jul 15, 2025
| @@ -1138,6 +1138,29 @@ class kernel_bundle_impl | |||
| DeviceGlobalMap MDeviceGlobals{/*OwnerControlledCleanup=*/false}; | |||
| }; | |||
|
|
|||
| inline bool is_compatible(const std::vector<kernel_id> &KernelIDs, | |||
There was a problem hiding this comment.
source/kernel_bundle.cpp provides bool is_compatible(const std::vector<kernel_id> &KernelIDs, const device &Dev) and is a public SYCL API, but we don't have sycl::device inside program_manager anymore, so what I'm doing here is moving implementation to here and modifying that public API to be just a thin wrapper about this method. That way program_manager can call this without creating sycl::device object.
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
…e_impl *` intel#18251 extended `device_impl`s' lifetimes until shutdown and intel#18270 started to pass devices as raw pointers in some of the APIs. This PR builds on top of that and extends usage of raw pointers/references/`device_range` as the devices are known to be alive and extra `std::shared_ptr`'s atomic increments aren't necessary and could be avoided. This change mostly touches `device_image_impl` and `program_manager` and switches most of the APIs to use `devices_range`. A few number of other modifications are caused by these APIs' changes and are necessary to keep the code buildable.
aelovikov-intel
force-pushed
the
device_image_impl
branch
from
ef174e8 to
a613be7
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18251 extended
device_impls' lifetimes until shutdown and #18270 started to pass devices as raw pointers in some of the APIs.This PR builds on top of that and extends usage of raw pointers/references/
device_rangeas the devices are known to be alive and extrastd::shared_ptr's atomic increments aren't necessary and could be avoided.Since we change the type of
device_image_impl::MDevices, other APIs in that class and inprogram_managerdon't need to operate in terms ofsycl::deviceorstd::shared_ptr<device_impl>and we can switch them to usedevices_rangeinstead. A small number of other modifications are caused by these APIs' changes and are necessary to keep the code buildable.One extra change is the addition of a minor
devices_range::to<std::vector<ur_device_handle_t>>()helper that we can use now that most of the arguments aredevice_range. Technically, could go in another PR but then we'd just be modifying the exact same lines two times, so I decided to fuse it here.