[UR][Offload] Event waiting #19594
[UR][Offload] Event waiting #19594
Conversation
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Implement urEventsWait[WithBarrier] and respect the waitlist of enqueue functions.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
|
||
| // Create events on each active queue for an arbitrary thread to block on | ||
| // TODO: Can we efficiently check if each thread is "finished" rather than | ||
| // creating an event? |
There was a problem hiding this comment.
stream_queue_t::syncEvents has some optimizations to only sync streams that need to be
There was a problem hiding this comment.
stream_queue_t::syncEvents doesn't seem to exist. stream_queue_t::syncStreams does, but doesn't seem to exclude completed threads as far as I can tell.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| } | ||
|
|
||
| // Ensure any newly created work waits on this barrier | ||
| auto OldEvent = hQueue->Barrier.exchange(BarrierEvent); |
There was a problem hiding this comment.
if exchange failed, that means that a newer barrier was created by a different thread. This means we should probably deallocate BarrierEvent at the end of this function.
Tbh, I think I'd just use a lock.
There was a problem hiding this comment.
I think this logic is sound when it comes to threading. What pattern are you seeing where it isn't?
Replacing the atomic with a lock feels like it'd slow queuing down quite a bit (since every enqueue would have to acquire the lock). Although, I agree it's much easier to reason about.
There was a problem hiding this comment.
Just decided to switch it over to a mutex.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Implement urEventsWait[WithBarrier] and respect the waitlist of enqueue
functions.