[CI] Add precompiled CTS tests to sycl_prebuilt_tests image #20332
Conversation
|
@aelovikov-intel ping for awareness |
|
Test run at https://github.com/intel/llvm/actions/runs/18386413684 CTS tests are running as expected, but there seems to be a single failure. It doesn't seem to be related to the workflow, but I still need to look into why it is failing. |
| testing_mode: ${{ inputs.cts_testing_mode }} | ||
| binaries_artifact: ${{ inputs.sycl_cts_artifact }} |
There was a problem hiding this comment.
If you can outline those changes into a separate PR, that would be awesome.
| # Author: Tom Deakin <[email protected]> | ||
| # Date: Thu Jul 10 16:45:48 2025 +0100 | ||
| # Merge pull request #1102 from steffenlarsen/steffen/remove_secondary_queue_exceptions | ||
| # Remove expected exceptions for secondary queue | ||
| ref: 19e4ed34377c8a8a354d701772427be8c5430b0d |
There was a problem hiding this comment.
That should be controlled by the inputs and set from the yml building the docker image.
| toolchain_artifact: toolchain | ||
| toolchain_artifact_filename: toolchain.tar.zst | ||
| e2e_binaries_artifact: e2e_bin | ||
| cts_binaries_artifact: cts_bin |
There was a problem hiding this comment.
This should also contain the cache. I think it should be something like this:
- in trunk, default to main branch or whatever is the trunk in the cts repo
- for manual dispatch, that should be an input with the default matching the above. I'm not sure if that should be a string input or a choice. Maybe a choice would be better because you'd be able to provide the hard-coded hash and its description. Note that manual dispatch is how we create those images currently.
- for sycl-rel-* branches I'd expect this job to have the hardcoded hash (but I don't think this job is enabled in post-commit of the sycl-rel-* branches)
|
Let's also update the description in sycl-prebuilt-e2e-container.yml: llvm/.github/workflows/sycl-prebuilt-e2e-container.yml Lines 3 to 5 in dabf72a |
| testing_mode: build-only | ||
| target_devices: all | ||
| binaries_artifact: ${{ inputs.cts_binaries_artifact }} | ||
| sycl_compiler: $GITHUB_WORKSPACE/toolchain/bin/clang++ |
There was a problem hiding this comment.
Just curious - why do we need this sycl_compiler?
| ref: | ||
| description: "Commit SHA or branch to checkout tests" | ||
| required: true | ||
| binaries_artifact: |
There was a problem hiding this comment.
BTW there is also windows/run-tests/cts/action.yml. Could you please update variables here as well & therefore sycl-windows-run-tests.yml (also maybe worth moving cts & e2e dirs to linux dir to align these things)?
3 participants
This PR adds precompiled CTS binaries to
sycl-prebuilt-e2e-container.yml.Note that this PR also renames some fields in
devops/actions/run-tests/cts/action.ymlto match that ofrun-tests/e2e/action.yml. If this is unwanted I will undo the changes.