[SYCL] Move device_selector to the detail namespace#22363
Closed
KornevNikita wants to merge 5 commits into
Closed
Conversation
The class has been removed in SYCL 2020. Move it to the detail namespace to keep support for legacy selectors while making it invisible to users. Prepare all classes/functions that are using this class for this move, i.e. update some to use detail::device_selector and remove the rest that is not part of SYCL 2020.
KornevNikita
commented
Jun 18, 2026
| inline namespace _V1 { | ||
|
|
||
| // Forward declaration | ||
| class device_selector; |
Contributor
Author
There was a problem hiding this comment.
note - redundant FD, not used in this file.
KornevNikita
commented
Jun 18, 2026
|
|
||
| // Forward declarations | ||
| class device; | ||
| class device_selector; |
Contributor
Author
There was a problem hiding this comment.
note - redundant FD. The filter_selector class uses device_selector as a base class and therefore needs #include.
Contributor
Author
|
Closing in favor of #22423 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class has been removed in SYCL 2020. Move it to the detail namespace to keep support for legacy selectors while making it invisible to users.
Prepare all classes/functions that are using this class for this move, i.e. update some to use detail::device_selector and remove the rest that is not part of SYCL 2020.
FYI - KhronosGroup/SYCL-Docs#1018