Skip to content

[NFC] Remove accidentally commited ccache folder#22393

Open
jsji wants to merge 1 commit into
intel:syclfrom
jsji:rmccachedir
Open

[NFC] Remove accidentally commited ccache folder#22393
jsji wants to merge 1 commit into
intel:syclfrom
jsji:rmccachedir

Conversation

@jsji

@jsji jsji commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Folder was added accidentally in conflict resolution. Added the folder to .gitignore as well.

@jsji jsji requested a review from bader as a code owner June 23, 2026 02:20
@jsji jsji self-assigned this Jun 23, 2026
Comment thread .gitignore

#pulldown temp folder
/spirv-patches-*
/ccache-sycl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this? Can you put ccache files/directory to one of existing directories?
For example, this file already has a rule for:

  • .cache
  • /build*

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can change other scripts to move the ccache, but I think it would be easier and safer to add it here. This won't cause additional issue given we have other customizations like !buidbot above.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need to add a new rule for local ccache directory, I suggest following standard naming scheme:

Suggested change
/ccache-sycl
/.ccache/ # e.g. .ccache/sycl/, .ccache/main/, etc.

@dm-vodopyanov

Copy link
Copy Markdown
Contributor

@jsji, hi, do you have a plan to address the feedback from Alexey above and merge the fix? ccache-sycl is still in the repo.

@bader

bader commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@jsji, hi, do you have a plan to address the feedback from Alexey above and merge the fix? ccache-sycl is still in the repo.

@dm-vodopyanov, @jsji is OOO this week. I'm okay to address the comment later, but someone need to fix CI before merging this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants