Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Implement native_specialization_constant() #8613

Merged
merged 1 commit into from
Mar 10, 2023
Merged

[SYCL] Implement native_specialization_constant() #8613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions sycl/source/detail/device_image_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,19 @@ class device_image_impl {
}

bool all_specialization_constant_native() const noexcept {
assert(false && "Not implemented");
return false;
// Specialization constants are natively supported in JIT mode on backends,
// that are using SPIR-V as IR
auto IsAOTBinary = [](const char *Format) {
return (
(strcmp(Format, __SYCL_PI_DEVICE_BINARY_TARGET_SPIRV64_X86_64) ==
0) ||
(strcmp(Format, __SYCL_PI_DEVICE_BINARY_TARGET_SPIRV64_GEN) == 0) ||
(strcmp(Format, __SYCL_PI_DEVICE_BINARY_TARGET_SPIRV64_FPGA) == 0));
Comment on lines +116 to +120
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead do something like Format != JIT SPIR TARGET? I understand that it might be more tricky, because that target string is probably a substring of AOT targets, but it should allow us to do less string comparisons.

};

return !IsAOTBinary(MBinImage->getRawData().DeviceTargetSpec) &&
(MContext.get_backend() == backend::opencl ||
MContext.get_backend() == backend::ext_oneapi_level_zero);
Comment on lines +123 to +125
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those checks should be re-ordered: we should do less expensive backend checks first and only then do more expensive string comparison checks.

}

bool has_specialization_constant(const char *SpecName) const noexcept {
Expand Down