[SYCL] Introduce sycl complex marray specialization #8647
Conversation
…ce-sycl_complex_marray-implementation
|
The latest commits are the propagation of this PR intel/llvm-test-suite#1661 which was on the recently archived llvm-test-suite repository. |
|
Is there anything else you wanted me to update regarding this PR @steffenlarsen ? |
…ce-sycl_complex_marray-implementation
jle-quel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jle-quel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Have you seen this #12786 @steffenlarsen? |
I missed that! Thanks for pointing it out. 😄 |
…ce-sycl_complex_marray-implementation
|
With the latest changes made to the specification, I believe the two comments that you left @steffenlarsen about the deleted operators are resolved. The specification explicitly marked the operators as deleted. The implementation just does not have to define them, nor delete them. Are we okay with that? The last comment that needs to be resolved before this PR can get merged is the one at "#8647 (comment)". I'm not sure I fully understand what needs to be done. Could you please be more specific? |
We refactored the builtins, so the comment was about making these new builtins similar in definition to the new structure. See https://github.com/intel/llvm/blob/sycl/sycl/include/sycl/detail/builtins/math_functions.inc and https://github.com/intel/llvm/blob/sycl/sycl/include/sycl/detail/builtins/helper_macros.hpp. |
I've updated the implementation of the marray builtin to follow the new structure of the builtins. However, it is a bit more convoluted since we are merging a common interface but with different arguments and logic within that function. I've added some comments to help understand the macros and how to create a new builtin if needed in the future. Let me know what you think @steffenlarsen |
…ce-sycl_complex_marray-implementation
|
This pull request is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be automatically closed in 30 days. |
|
This pull request was closed because it has been stalled for 30 days with no activity. |
Following the introduction of
sycl::ext::oneapi::experimental::complex(#8068), which adds the support of complex for SYCL, this PR allows for adding new complex math features.The specialization of
sycl::marrayto add support for storing complex numbers in arrays is proposed as well as overloading the existing math functions to support complex marrays and adding member functions to simplify accessing, setting marray values, and constructing complex marrays.