Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][L0] Reenable native memcpy2d path for L0 #9973

Draft
wants to merge 6 commits into
base: sycl
Choose a base branch
from
Draft

[SYCL][L0] Reenable native memcpy2d path for L0 #9973

wants to merge 6 commits into from

Conversation

steffenlarsen
Copy link
Contributor

#8609 disabled the use of native memcpy2d backend calls in the L0 plugin due to a bug for non-USM pointers. This commit reenables it.

@steffenlarsen
[SYCL][L0] Reenable native memcpy2d path for L0
112e8e7 
intel#8609 disabled the use of native
memcpy2d backend calls in the L0 plugin due to a bug for non-USM
pointers. This commit reenables it.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen requested review from a team as code owners June 19, 2023 12:57
@steffenlarsen steffenlarsen temporarily deployed to aws June 19, 2023 13:13 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws June 19, 2023 13:49 — with GitHub Actions Inactive
@jandres742
Copy link
Contributor

@steffenlarsen

#8609 disabled the use of native memcpy2d backend calls in the L0 plugin due to a bug for non-USM pointers

so is that bug fixed? Or are we re-enabling to see if the bug is still there?

@steffenlarsen
Copy link
Contributor Author

@steffenlarsen

#8609 disabled the use of native memcpy2d backend calls in the L0 plugin due to a bug for non-USM pointers

so is that bug fixed? Or are we re-enabling to see if the bug is still there?

It was as much an attempt to see if it had been fixed in the driver used in our CI. It seems like it hasn't.

@steffenlarsen steffenlarsen marked this pull request as draft June 20, 2023 05:44
@jandres742
Copy link
Contributor

@steffenlarsen

#8609 disabled the use of native memcpy2d backend calls in the L0 plugin due to a bug for non-USM pointers

so is that bug fixed? Or are we re-enabling to see if the bug is still there?

It was as much an attempt to see if it had been fixed in the driver used in our CI. It seems like it hasn't.

Thanks @steffenlarsen . I remember sync'ing with @smaslov-intel previously and he had mentioned this issue. I will take a look to see if we can fix the issue and report back.

@pbalcer pbalcer mentioned this pull request Apr 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@smaslov-intel smaslov-intel smaslov-intel approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steffenlarsen @jandres742 @bader @smaslov-intel