-
Notifications
You must be signed in to change notification settings - Fork 277
Use SafeUnpickler #2247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SafeUnpickler #2247
Conversation
Signed-off-by: yiliu30 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a security improvement by replacing the unsafe pickle.load()
with a custom SafeUnpickler
class to prevent arbitrary code execution during deserialization of tuning history files.
- Implements a custom
SafeUnpickler
class with restricted class loading - Replaces direct
pickle.load()
usage with the safer alternative - Adds necessary imports for
builtins
andOrderedDict
Co-authored-by: Copilot <[email protected]>
Signed-off-by: yiliu30 <[email protected]>
…ressor into fix-tuning-his
Signed-off-by: yiliu30 <[email protected]>
Signed-off-by: yiliu30 <[email protected]>
…ressor into fix-tuning-his
@chensuyue @XuehaoSun
|
This is why the test failed, but looks like your PR fix the issue. Because it's pass in PR test, failed in baseline. |
Type of Change
feature or bug fix or documentation or validation or others
API changed or not
Description
detail description
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed