Skip to content

Fix failing dimension check for MAX operation. #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

rayngun
Copy link

@rayngun rayngun commented Feb 6, 2025

No description provided.

@rayngun rayngun marked this pull request as ready for review February 6, 2025 01:16
@sfatimar
Copy link

sfatimar commented Feb 7, 2025

@saurabhkale17 please review

@sfatimar
Copy link

@saurabhkale17 @rayngun PR is unblocked now, Please rebase and ready to merge. Please finish review process.

@saurabhkale17
Copy link

@rayngun Can you please rebase the branch
27 file changes.

jatinwadhwa921 and others added 2 commits February 11, 2025 17:03
* update: Update MSFT Contrib Ops from OV

* modified data_ops.cc to remove unsupported ops

* disabled tests for EmbedLayerNormalisation and MatMulNBits

---------

Co-authored-by: n1harika <[email protected]>
@rayngun rayngun reopened this Feb 11, 2025
@saurabhkale17
Copy link

LGTM.
@sfatimar should I merge it in ?

@sfatimar
Copy link

Internal CI is failing @jatinwadhwa921 I am merging anyways as it is open for long time.

@sfatimar sfatimar merged commit a153164 into intel:ovep-develop Feb 13, 2025
2 of 10 checks passed
ankitm3k added a commit that referenced this pull request Feb 17, 2025
* Internal ci for PTL 1.1 (#523)

* update: Update MSFT Contrib Ops in OVEP (#521)

* update: Update MSFT Contrib Ops from OV

* modified data_ops.cc to remove unsupported ops

* disabled tests for EmbedLayerNormalisation and MatMulNBits

---------

Co-authored-by: n1harika <[email protected]>

* Add Max op to no_dimension_supported list

---------

Co-authored-by: jatinwadhwa921 <[email protected]>
Co-authored-by: Ankit Maheshkar <[email protected]>
Co-authored-by: n1harika <[email protected]>
ankitm3k added a commit that referenced this pull request Feb 17, 2025
* Internal ci for PTL 1.1 (#523)

* update: Update MSFT Contrib Ops in OVEP (#521)

* update: Update MSFT Contrib Ops from OV

* modified data_ops.cc to remove unsupported ops

* disabled tests for EmbedLayerNormalisation and MatMulNBits

---------

Co-authored-by: n1harika <[email protected]>

* Add Max op to no_dimension_supported list

---------

Co-authored-by: jatinwadhwa921 <[email protected]>
Co-authored-by: Ankit Maheshkar <[email protected]>
Co-authored-by: n1harika <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants