handling duplicate dq which are initializers #575
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update: Update MSFT Contrib Ops from OV * modified data_ops.cc to remove unsupported ops * disabled tests for EmbedLayerNormalisation and MatMulNBits --------- Co-authored-by: n1harika <[email protected]>
ankitm3k
force-pushed
the
ovep-develop
branch
from
5e0f026 to
781f620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where duplicate DQ nodes which are initializers were incorrectly removed. Since initializers should always be preserved, the fix ensures that:
All duplicate DQ nodes that are initializers are now retained.
Other DQ Nodes: Duplicate DQ nodes that are not initializers continue to be handled according to the existing rule set.
This change guarantees proper handling of initializers and aligns with the expected behavior of preserving important model components.
Note: this is a draft PR . Functional and accuracy validation is in progress for other all important models. This fix will be merged post functional and accuracy validation