Rely on optimum-cli to be on PATH #202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenchwr
force-pushed
the
main
branch
2 times, most recently
from
80342bd to
26a6877
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I'm working on updating the snap to v3.1.2 and this line is a bit problematic because it assumes
optimum-cliwill be in the same directory as the python executable (which is not the case in the snap).I haven't tested this in other environments - only the snap - so it's possible I haven't accounted for something. Are there cases where you expect
optimum-cliwill not be on the system's search path (e.g.PATHin Linux)?