GQA #623
Draft
GQA #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunjiweiswift
force-pushed
the
fmha_GQA
branch
from
ae53435 to
b62b28d
Compare
sunjiweiswift
force-pushed
the
fmha_GQA
branch
9 times, most recently
from
5cb846f to
90a414a
Compare
airMeng
reviewed
Nov 17, 2025
airMeng
left a comment
airMeng
left a comment
There was a problem hiding this comment.
Based on my XeTLA experience, Q-head folding improves decoding performance but hurts prefill. Should this optimization be made conditional, similar to reduce_A ?
sunjiweiswift
force-pushed
the
fmha_GQA
branch
2 times, most recently
from
e8576ac to
c114d9f
Compare
sunjiweiswift
force-pushed
the
fmha_GQA
branch
from
c114d9f to
b5af73f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type
Testing
Performance
References
Fixes #
Checklist