Support FP8 in op flip, index_put, and index.Tensor #2190
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds FP8 support to XPU tensor operations including flip, index, and index_put operations by migrating from legacy dispatch macros to the newer AT_DISPATCH_V2 system.
- Migrates flip_kernel from AT_DISPATCH_ALL_TYPES_AND_COMPLEX_AND3 to AT_DISPATCH_V2
- Migrates index_kernel and index_put_kernel from AT_DISPATCH_ALL_TYPES_AND_COMPLEX_AND4 to AT_DISPATCH_V2
- Adds FP8 type support through AT_FLOAT8_TYPES expansion
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ATen/native/xpu/sycl/TensorTransformationsKernels.cpp | Updates flip_kernel to use AT_DISPATCH_V2 with FP8 support |
| src/ATen/native/xpu/sycl/Indexing.cpp | Updates index_kernel and index_put_kernel to use AT_DISPATCH_V2 with FP8 support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| }); | ||
| }), | ||
| AT_EXPAND(AT_ALL_TYPES_AND_COMPLEX), | ||
| AT_EXPAND(AT_FLOAT8_TYPES), |
There was a problem hiding this comment.
Missing AT_EXPAND(AT_BAREBONES_UNSIGNED_TYPES) that was included in the flip_kernel implementation. For consistency across operations, this should be added.
| AT_EXPAND(AT_FLOAT8_TYPES), | |
| AT_EXPAND(AT_FLOAT8_TYPES), | |
| AT_EXPAND(AT_BAREBONES_UNSIGNED_TYPES), |
Copilot uses AI. Check for mistakes.
| }); | ||
| }), | ||
| AT_EXPAND(AT_ALL_TYPES_AND_COMPLEX), | ||
| AT_EXPAND(AT_FLOAT8_TYPES), |
There was a problem hiding this comment.
Missing AT_EXPAND(AT_BAREBONES_UNSIGNED_TYPES) that was included in the flip_kernel implementation. For consistency across operations, this should be added.
| AT_EXPAND(AT_FLOAT8_TYPES), | |
| AT_EXPAND(AT_FLOAT8_TYPES), | |
| AT_EXPAND(AT_BAREBONES_UNSIGNED_TYPES), |
Copilot uses AI. Check for mistakes.
|
1 participant
Fix Issue:#1939