Skip to content

Reduces excessive logging in QAT mode #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asonje wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Reduces excessive logging in QAT mode #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b7f646e
Adds test to validate log_stats_samples config
asonje Oct 23, 2025
35fc535
Merge branch 'intel:main' into main
asonje Dec 9, 2025
db531ff
Reduces excessive error logging in QAT mode
asonje Dec 18, 2025
5d513a4
Bugfix for the log stream
asonje Dec 18, 2025
9aff4f8
Treats QPL_STS_MORE_OUTPUT_NEEDED as a non error condition for IAA
asonje Dec 18, 2025
806ce1d
Fixed formatting
asonje Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iaa.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ int UncompressIAA(uint8_t* input, uint32_t* input_length, uint8_t* output,
job->dictionary = nullptr;

qpl_status status = qpl_execute_job(job);
if (status != QPL_STS_OK) {
if (status != QPL_STS_OK && status != QPL_STS_MORE_OUTPUT_NEEDED) {
Log(LogLevel::LOG_ERROR, "UncompressIAA() Line ", __LINE__,
" qpl_execute_job status ", status, "\n");
return 1;
Expand Down
1 change: 1 addition & 0 deletions logging.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ inline void Log(LogLevel level, Args&&... args) {
}

std::ostream& stream = GetLogStream();
stream << std::dec;
switch (level) {
case LogLevel::LOG_ERROR:
stream << "Error: ";
Expand Down
1 change: 1 addition & 0 deletions qat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ void QATJob::Init(QzSessionPtr &qzSession, CompressedFormat format,
}

// Initialize QAT hardware
qzSetLogLevel(LOG_NONE);
int status = qzInit(session.get(), 0);
if (status != QZ_OK && status != QZ_DUPLICATE) {
Log(LogLevel::LOG_ERROR, "qzInit() failure Line ", __LINE__, " session ",
Expand Down
2 changes: 2 additions & 0 deletions qat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

#define VISIBLE_FOR_TESTING __attribute__((visibility("default")))

inline constexpr unsigned int QAT_DEST_BUFFER_MIN_SIZE = 512;

inline constexpr unsigned int QAT_HW_BUFF_SZ = QZ_HW_BUFF_MAX_SZ;

class QATJob {
Expand Down
3 changes: 1 addition & 2 deletions zlib_accel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ int ZEXPORT deflate(z_streamp strm, int flush) {
#endif
#ifdef USE_QAT
qat_available =
configs[USE_QAT_COMPRESS] &&
configs[USE_QAT_COMPRESS] && output_len >= QAT_DEST_BUFFER_MIN_SIZE &&
SupportedOptionsQAT(deflate_settings->window_bits, input_len);
#endif

Expand Down Expand Up @@ -1352,7 +1352,6 @@ int ZEXPORT gzeof(gzFile file) {
GzipFile* gz = gzip_files.Get(file);
return gz->reached_eof;
}

#if defined(__clang__)
#pragma clang attribute pop
#endif