Skip to content

Fix pg_dump call #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix pg_dump call #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/pliny/tasks/db.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ begin
require "sequel"
require "sequel/extensions/migration"
require "pliny/db_support"
require "shellwords"

namespace :db do
desc "Get current schema version"
Expand Down Expand Up @@ -109,7 +110,11 @@ begin
task :dump do
file = File.join("db", "schema.sql")
database_url = database_urls.first
`pg_dump -s -x -O -f #{file} #{database_url}`
`pg_dump -s -x -O -f #{file.shellescape} #{database_url.shellescape}`
if $?.exitstatus != 0
puts "Failed to dump schema"
exit 1
end

schema = File.read(file)
# filter all COMMENT ON EXTENSION, only owners and the db
Expand Down