Feat/Currency Conversion#15
Merged
Merged
Conversation
ngodi
reviewed
May 30, 2025
ngodi
reviewed
May 30, 2025
ngodi
approved these changes
May 30, 2025
- resolved all lint errors - created BaseBitnobService class so it can reused in currencyService - removed duplicated code
Merge branch 'feat/currency-conversion' of https://github.com/internPulse-cohort8/bitnob-api-nodejs into feat/currency-conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bitnob API Integration
Overview
This PR implements a Node.js API service that integrates with the Bitnob API to provide currency conversion and exchange rate functionality. The implementation follows a clean architecture pattern with proper separation of concerns and robust error handling.
Features Implemented
1. Currency Conversion
POST /api/currency/convert2. Exchange Rate Information
GET /api/currency/rates3. Specific Currency Rate
GET /api/currency/rate/:currencyTechnical Implementation Details
Architecture
Key Components
Currency Service
Input Validation
Error Handling
Dependencies
Testing
Security
Documentation
README.mdwith setup instructions