added new tests for zones_controller #2813
Conversation
| get new_admin_zone_path | ||
| assert_response :success | ||
|
|
||
| unless response.body.include?('<form') |
There was a problem hiding this comment.
remove this block. It is okey, when you debug by yourself, but when code is completed, some debug approaches need to remove
| puts response.body | ||
| end | ||
|
|
||
| assert_includes response.body, '<form', "'form' element not found" |
There was a problem hiding this comment.
Honestly, this looks more like a test for an error or something along those lines. Correct me if I’m wrong?
There was a problem hiding this comment.
I was just too eager. Removed.
| get admin_zones_path | ||
| assert_response :success | ||
|
|
||
| unless response.body.include?('<table') |
| puts response.body | ||
| end | ||
|
|
||
| assert_includes response.body, '<table', "'table' element not found" |
| follow_redirect! | ||
| assert_response :success | ||
|
|
||
| # If the table is not found in response body, print the response body |
| puts response.body | ||
| end | ||
|
|
||
| assert_includes response.body, '<form', "'form' element not found" |
| def test_shows_edit_form | ||
| get edit_admin_zone_path(@zone) | ||
| assert_response :success | ||
| assert_includes response.body, '<form', "'form' element not found in edit form" |
There was a problem hiding this comment.
do we have some problem in UI?
There was a problem hiding this comment.
No., everything looks good on UI side. Removed.
| assert_response :success | ||
|
|
||
| # If the form is not found in response body, print the response body | ||
| unless response.body.include?('<form') |
| puts response.body | ||
| end | ||
|
|
||
| assert_includes response.body, '<form', "'form' element not found after invalid update" |
There was a problem hiding this comment.
if update is invalid, we should get notification about it. And this notification need to check.
| } | ||
| } | ||
|
|
||
| assert_redirected_to admin_zones_url |
There was a problem hiding this comment.
check manually it. Do we receive some notification after this operation? If we do, then also need to add one more assertion
New tests for zones_controller