Skip to content

Fix domain history ordering and current state display #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2025

Conversation

OlegPhenomenon
Copy link
Contributor

close #2822

  • Ensure "Current state" (pending/current domain) is always shown as the first row in domain history.
  • Sort post-update domain states by updated_at descending for correct chronological order.
  • Fix version navigation and sidebar highlighting for current state in domain version show view.
  • Unify logic for displaying domain and contact data in both history and single version views.
  • Remove legacy ObjectVersionsParser usage and handle nil @Version cases gracefully.
  • Refactor partials and controller logic to ensure all rows in history reflect the correct post-update state.

- Ensure "Current state" (pending/current domain) is always shown as the first row in domain history.
- Sort post-update domain states by updated_at descending for correct chronological order.
- Fix version navigation and sidebar highlighting for current state in domain version show view.
- Unify logic for displaying domain and contact data in both history and single version views.
- Remove legacy ObjectVersionsParser usage and handle nil @Version cases gracefully.
- Refactor partials and controller logic to ensure all rows in history reflect the correct post-update state.
@OlegPhenomenon OlegPhenomenon force-pushed the 2822-domain-history-shows-old-info branch from 2df8438 to 81e2c3a Compare July 17, 2025 08:31
@OlegPhenomenon OlegPhenomenon requested a review from maricavor July 17, 2025 08:31
@vohmar vohmar merged commit 30c8d46 into master Jul 30, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domain history shows old info
3 participants