Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binarization_util.py #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update binarization_util.py #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/fasterrisk/binarization_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,10 @@ def fit(self, df: pd.DataFrame) -> None:
for col_idx in range(len(self.cols)):
col = self.cols[col_idx]
col_value = df[col]


# Initialize tmp_num_thresholds *before* checking for NaNs
tmp_num_thresholds = self.max_num_thresholds_per_feature

if col_value.isnull().sum() > 0:
tmp_num_thresholds -= 1
binarizers.append({ # need to keep track of NaN for every column
Expand Down Expand Up @@ -267,4 +270,4 @@ def transform(self, df: pd.DataFrame) -> tuple:
def fit_transform(self, df: pd.DataFrame) -> pd.DataFrame:
'''fit and transform on same dataframe'''
self.fit(df)
return self.transform(df)
return self.transform(df)