Skip to content

Fix issues with installation on durable sys #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025

Conversation

isc-pbarton
Copy link
Collaborator

@isc-pbarton isc-pbarton commented Jun 26, 2025

Fixes #795
Use mgrDir rather than libDir to calculate path to studio templates directory. Should be compatible with all IPM versions.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.81%. Comparing base (573c292) to head (e4b46ec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #797   +/-   ##
=======================================
  Coverage   40.81%   40.81%           
=======================================
  Files          24       24           
  Lines        3239     3239           
=======================================
  Hits         1322     1322           
  Misses       1917     1917           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isc-pbarton isc-pbarton force-pushed the fix-install-durable-sys branch from dc4107f to e4b46ec Compare June 26, 2025 19:30
@isc-pbarton isc-pbarton requested a review from isc-npetroce June 26, 2025 19:31
@isc-pbarton isc-pbarton marked this pull request as ready for review June 26, 2025 19:31
@raymond-rebbeck
Copy link
Contributor

I was able to install this branch successfully with both IPM 0.7.4 and IPM 0.10.2

IRIS for UNIX (Ubuntu Server LTS for x86-64 Containers) 2024.1.4 (Build 516_1U) Sat May 31 2025 12:35:51 EDT

Copy link
Collaborator

@isc-npetroce isc-npetroce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isc-pbarton isc-pbarton merged commit 27947ce into main Jun 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install git-source-control due to /usr/irissys/ permissions
4 participants