Skip to content

[tooling] Move dev tools to a specifc group #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2025
Merged

[tooling] Move dev tools to a specifc group #1293

merged 1 commit into from
Nov 27, 2025

Conversation

@the-glu
Copy link
Contributor

@the-glu the-glu commented Nov 25, 2025 •
edited
Loading

  • Remove dev tools (like ruff) from base image.
  • Build a second image with dev tools
  • Use that second image to run unit test and hygiene
  • Remove useless apt package installed image the image

Fix #1121

@the-glu the-glu force-pushed the 1121 branch 6 times, most recently from 92865cb to c2bb671 Compare November 25, 2025 15:06
the-glu
the-glu commented Nov 25, 2025
View reviewed changes
pyproject.toml
]

[tool.uv]
default-groups = []
Copy link
Contributor Author

@the-glu the-glu Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev group is installed by default, but we don't want that ^^'

@the-glu the-glu marked this pull request as ready for review November 25, 2025 15:12
mickmis
mickmis reviewed Nov 26, 2025
View reviewed changes
mickmis
mickmis approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo clarification

@mickmis mickmis merged commit 4d2a686 into interuss:main Nov 27, 2025
21 checks passed
@mickmis mickmis deleted the 1121 branch November 27, 2025 08:51
github-actions bot added a commit that referenced this pull request Nov 27, 2025
@github-actions
[tooling] Move dev tools to a specifc group (#1293) 4d2a686
7380f57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mickmis mickmis mickmis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move tooling package into a specific image / dependency group

2 participants

@the-glu @mickmis