Skip to content

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Sep 2, 2025

Description

IMPORTANT - remember to code attribute when merging. Put this in the commit body on merge:

>
>
Co-authored-by: Daniel La Rocque <[email protected]>
Co-authored-by: hsubox76 <[email protected]>
Co-authored-by: Tanzim Hossain <[email protected]>
Co-authored-by: Josh Soref <[email protected]>
Co-authored-by: DellaBitta <[email protected]>

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Sep 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-native-firebase Ready Ready Preview Comment Sep 4, 2025 0:31am

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - I'm going to pull it locally and resolve the conflicts then re-push with the commit message already baked into the PR in the local squash commit I push out.

After I see that looking good via manual inspection it should be good for a clean rebase merge on to main, with attribution setup correctly 🤞

"@react-native-community/cli": "15.1.3",
"@react-native-community/cli-platform-android": "15.1.3",
"@react-native-community/cli-platform-ios": "15.1.3",
"@react-native-firebase/ai": "23.2.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course! the AI local test feature was the one I didn't test after porting manual tests into e2e app. No way it worked without this, sorry

- includes docs update with example usage
- includes unit tests and a local manual test in e2e app

----
Co-authored-by: Daniel La Rocque <[email protected]>
Co-authored-by: hsubox76 <[email protected]>
Co-authored-by: Tanzim Hossain <[email protected]>
Co-authored-by: Josh Soref <[email protected]>
Co-authored-by: DellaBitta <[email protected]>
@mikehardy mikehardy merged commit fb364ed into main Sep 4, 2025
17 of 21 checks passed
@mikehardy mikehardy deleted the imagen-api branch September 4, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants