Add install probes for T5_encoder and ClipTextModel #6800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstein
requested review from
blessedcoolant,
brandonrising,
RyanJDick and
hipsterusername
as code owners
lstein
changed the title
github-actions
bot
added
python
brandonrising
approved these changes
Sep 3, 2024
brandonrising
force-pushed
the
lstein/feat/probe-flux-models
branch
from
facca8c to
4a20ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During testing of the new Flux starter models, I found that installation of
clip-vit-largeand the quantized text encoders were failing during the model installer's model probe phase. This PR adds model probe support for the FLUX T5_encoder and ClipTextModel dependencies. This PR fixes "download failed" errors experienced when the FLUX starter models are installed.Related Issues / Discussions
QA Instructions
To confirm the original issue, please first remove the T5 quantized text encoder and clip-vit-large, and try to install one of the quantized Flux models from the Model manager starter models tab. This should fail.
After pulling this PR, these tasks should run to completion and flux-based workflows should work.
Merge Plan
Merge when approved.
Checklist