Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces multi-thread support for Opik tracing by decoupling tracer instantiation from setup and creating per-thread tracer instances.
- Store the Opik configuration in the agent and defer tracer creation.
- Add
_create_opik_tracerto instantiate a tracer for each thread. - Update
get_responseto attach a thread-specific tracer callback.
Comments suppressed due to low confidence (3)
src/expert/agent.py:104
- Add unit tests for
_create_opik_tracerto verify it returnsNonewhenopik_configis unset and correctly instantiates anOpikTracerwith the expected tags.
def _create_opik_tracer(self, user_thread_id: str) -> OpikTracer | None:
src/expert/agent.py:115
- Verify that
OpikTraceraccepts atagsparameter in this form; if it expects metadata key/value pairs, you may need to pass a dict liketags={"thread_id": user_thread_id}.
tags=[user_thread_id]
src/expert/agent.py:130
- [nitpick] Consider caching tracer instances per
thread_idto avoid recreating them on each request, which could reduce overhead.
tracer = self._create_opik_tracer(thread_id)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.